Bug 100105

Summary: Web Inspector: Floated anchor element sometimes overlaps following content.
Product: WebKit Reporter: Mike West <mkwst>
Component: Web Inspector (Deprecated)Assignee: Mike West <mkwst>
Status: RESOLVED FIXED    
Severity: Trivial CC: apavlov, keishi, loislo, me, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 97978    
Attachments:
Description Flags
Example of the bug on Ars Technica.
none
Post-patch.
none
Patch
none
Fixing top border. none

Mike West
Reported 2012-10-23 04:02:25 PDT
Console messages' anchor element is floated right, which means that it sometimes overlaps following messages.
Attachments
Example of the bug on Ars Technica. (47.08 KB, image/png)
2012-10-23 04:06 PDT, Mike West 		no flags
Details
Post-patch. (64.67 KB, image/png)
2012-10-23 04:42 PDT, Mike West 		no flags
Details
Patch (1.93 KB, patch)
2012-10-23 04:45 PDT, Mike West 		no flags
DetailsFormatted DiffDiff
Fixing top border. (2.19 KB, patch)
2012-10-23 04:59 PDT, Mike West 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Mike West
Comment 1 2012-10-23 04:06:14 PDT
Created attachment 170113 [details] Example of the bug on Ars Technica.
Mike West
Comment 2 2012-10-23 04:42:06 PDT
Created attachment 170121 [details] Post-patch.
Mike West
Comment 3 2012-10-23 04:45:08 PDT
Created attachment 170123 [details] Patch
Alexander Pavlov (apavlov)
Comment 4 2012-10-23 04:51:18 PDT
Comment on attachment 170123 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=170123&action=review > Source/WebCore/inspector/front-end/inspector.css:890 > + border-top: 1px solid rgb(240, 240, 240); Does this cause an unwanted top border for the first message?
Mike West
Comment 5 2012-10-23 04:56:21 PDT
(In reply to comment #4) > (From update of attachment 170123 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=170123&action=review > > > Source/WebCore/inspector/front-end/inspector.css:890 > > + border-top: 1px solid rgb(240, 240, 240); > > Does this cause an unwanted top border for the first message? Yes, it does. Crap. I'll spin a new patch in a moment.
Mike West
Comment 6 2012-10-23 04:59:31 PDT
Created attachment 170126 [details] Fixing top border.
Mike West
Comment 7 2012-10-23 05:01:03 PDT
(In reply to comment #6) > Created an attachment (id=170126) [details] > Fixing top border. This patch sets `border-top` to `none` for `.console-message:first-child`.
WebKit Review Bot
Comment 8 2012-10-23 09:07:50 PDT
Comment on attachment 170126 [details] Fixing top border. Clearing flags on attachment: 170126 Committed r132230: <http://trac.webkit.org/changeset/132230>
WebKit Review Bot
Comment 9 2012-10-23 09:07:54 PDT
All reviewed patches have been landed. Closing bug.
Nikita Vasilyev
Comment 10 2012-11-01 07:09:09 PDT
.console-message {overflow: hidden} seems to be the simpler solution.
Note You need to log in before you can comment on or make changes to this bug.