Bug 101353

Summary:

[WTR] Reset EventSender before running each test.

Product:

WebKit

Reporter:

Raphael Kubo da Costa (:rakuco) <rakuco>

Component:

Tools / Tests

Assignee:

Raphael Kubo da Costa (:rakuco) <rakuco>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

gustavo, kenneth, mrobinson, ossy, philn, sam, simon.fraser, xan.lopez, zan

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Add dummy destructors to the mac/gtk/qt ports	none
Patch	simon.fraser: review+

Raphael Kubo da Costa (:rakuco)

Reported 2012-11-06 07:49:08 PST

[WTR] Reset EventSender before running each test.

Attachments
Patch (2.60 KB, patch) 2012-11-06 07:51 PST, Raphael Kubo da Costa (:rakuco)	no flags	Details Formatted Diff Diff
Add dummy destructors to the mac/gtk/qt ports (4.66 KB, patch) 2012-11-06 08:06 PST, Raphael Kubo da Costa (:rakuco)	no flags	Details Formatted Diff Diff
Patch (4.78 KB, patch) 2012-11-06 08:24 PST, Raphael Kubo da Costa (:rakuco)	simon.fraser: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Raphael Kubo da Costa (:rakuco)

Comment 1 2012-11-06 07:51:31 PST

Created attachment 172588 [details] Patch

Raphael Kubo da Costa (:rakuco)

Comment 2 2012-11-06 07:53:26 PST

Comment on attachment 172588 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172588&action=review > Tools/WebKitTestRunner/TestController.cpp:507 > + // Reset the EventSender for each test. > +#if PLATFORM(MAC) || PLATFORM(QT) || PLATFORM(GTK) || PLATFORM(EFL) > + m_eventSenderProxy = adoptPtr(new EventSenderProxy(this)); > +#endif I'm not 100% sure this is the best place to do it (we could make EventSendingController::makeWindowObject() send a message and act when it is received, for example), or whether calling some EventSenderProxy::resetState() makes more sense. I'm open to suggestions.

Early Warning System Bot

Comment 3 2012-11-06 07:58:40 PST

Comment on attachment 172588 [details] Patch Attachment 172588 [details] did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/14728855

Raphael Kubo da Costa (:rakuco)

Comment 4 2012-11-06 08:06:38 PST

Created attachment 172590 [details] Add dummy destructors to the mac/gtk/qt ports

Build Bot

Comment 5 2012-11-06 08:17:55 PST

Comment on attachment 172590 [details] Add dummy destructors to the mac/gtk/qt ports Attachment 172590 [details] did not pass win-ews (win): Output: http://queues.webkit.org/results/14758008

Raphael Kubo da Costa (:rakuco)

Comment 6 2012-11-06 08:24:16 PST

Created attachment 172595 [details] Patch

Rafael Brandao

Comment 7 2012-11-06 08:42:11 PST

Comment on attachment 172595 [details] Patch LGTM.

Simon Fraser (smfr)

Comment 8 2012-11-06 09:58:44 PST

Comment on attachment 172595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172595&action=review > Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:88 > +EventSenderProxy::~EventSenderProxy() > +{ > +} Is there any port that requires a non-empty destructor? If not, you could remove them all.

Raphael Kubo da Costa (:rakuco)

Comment 9 2012-11-06 14:51:54 PST

(In reply to comment #8) > (From update of attachment 172595 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=172595&action=review > > > Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:88 > > +EventSenderProxy::~EventSenderProxy() > > +{ > > +} > > Is there any port that requires a non-empty destructor? If not, you could remove them all. The EFL one currently clears the list of selected touch points when ENABLE(TOUCH_EVENTS) is on, so I guess it makes sense to keep these for now.

Raphael Kubo da Costa (:rakuco)

Comment 10 2012-11-06 15:05:37 PST

Committed r133676: <http://trac.webkit.org/changeset/133676>

Csaba Osztrogonác

Comment 11 2012-11-06 22:40:08 PST

*** Bug 92231 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.