Bug 101552

Summary: Add properties for week/month picker in DateTimeChooserImpl::writeDocument
Product: WebKit Reporter: Keishi Hattori <keishi>
Component: FormsAssignee: Keishi Hattori <keishi>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, fishd, jamesr, tkent, tkent+wkapi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 100938    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Keishi Hattori
Reported 2012-11-07 23:35:11 PST
Add properties for week/month picker in DateTimeChooserImpl::writeDocument
Attachments
Patch (4.82 KB, patch)
2012-11-07 23:42 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (6.28 KB, patch)
2012-11-08 03:31 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Patch (6.23 KB, patch)
2012-11-08 04:05 PST, Keishi Hattori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Keishi Hattori
Comment 1 2012-11-07 23:42:55 PST
Created attachment 172940 [details] Patch
Kent Tamura
Comment 2 2012-11-07 23:55:05 PST
Comment on attachment 172940 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172940&action=review > Source/WebKit/chromium/ChangeLog:8 > + min/max for month picker should be months since epoch. todayLabel should be ThisWeek/ThisMonth for week/month pickers. And we need to add "mode" property. How about "weekLabel"? > Source/WebKit/chromium/src/DateTimeChooserImpl.cpp:100 > + minDate.setMillisecondsSinceEpochForDate(m_parameters.minimum); > + maxDate.setMillisecondsSinceEpochForDate(m_parameters.maximum); Are you sure passing yyyy-mm-dd for mode:week?
Keishi Hattori
Comment 3 2012-11-08 03:31:20 PST
Created attachment 172991 [details] Patch
WebKit Review Bot
Comment 4 2012-11-08 03:34:52 PST
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Kent Tamura
Comment 5 2012-11-08 03:43:26 PST
Comment on attachment 172991 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=172991&action=review > Source/Platform/chromium/public/WebLocalizedString.h:105 > + WeekNumberLabel, > WeekFormatTemplate, should keep alphabetical order
Keishi Hattori
Comment 6 2012-11-08 04:05:07 PST
Created attachment 173002 [details] Patch
WebKit Review Bot
Comment 7 2012-11-08 09:43:48 PST
Comment on attachment 173002 [details] Patch Clearing flags on attachment: 173002 Committed r133910: <http://trac.webkit.org/changeset/133910>
WebKit Review Bot
Comment 8 2012-11-08 09:43:52 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.