Bug 113927

Created attachment 196452 [details] Patch

Comment on attachment 196452 [details] Patch Attachment 196452 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17493040

LGTM. But, it looks ews and buildbots may need to be re-started. I will check ews and buildbots I maintain. CC'ing dominik. could you check your bots after landing this patch ?

But, it looks you need to bump glib in order to bump libsoup. checking for GLIB - version >= 2.35.0... no *** Could not run GLIB test program, checking why... *** The test program failed to compile or link. See the file config.log for the *** exact error that occured. This usually means GLIB is incorrectly installed. configure: error: GLIB 2.35.0 or later is required to build libsoup *** Error during phase configure of libsoup: ########## Error running ./configure --prefix /home/gyuyoung/webkit/WebKit/WebKitBuild/Dependencies/Root --libdir '/home/gyuyoung/webkit/WebKit/WebKitBuild/Dependencies/Root/lib64' --without-gnome --disable-introspection --disable-static --disable-gtk-doc *** [10/29]

Created attachment 196460 [details] Patch The problem with the EWS is that libsoup 2.42.0 requires a newer GLib version. Uploading a new patch bumping GLib too.

So it seems that now the patch breaks EFL build because of the deprecated functions in libsoup (which is fixed in bug #104894). Should I mix both patches in just one including remove of deprecated API and bumping of EFL versions? First it seems to me that having separate patches would be a good idea but maybe it is not.

Comment on attachment 196460 [details] Patch Attachment 196460 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17487089

(In reply to comment #6) > So it seems that now the patch breaks EFL build because of the deprecated functions in libsoup (which is fixed in bug #104894). > > Should I mix both patches in just one including remove of deprecated API and bumping of EFL versions? > > First it seems to me that having separate patches would be a good idea but maybe it is not. I'd say let's keep them separate, get both reviewed and then manually commit in short succession.

Comment on attachment 196460 [details] Patch Attachment 196460 [details] did not pass efl-ews (efl): Output: http://webkit-commit-queue.appspot.com/results/17478053

Comment on attachment 196460 [details] Patch r=me. But, please land this patch when Bug 104894 is ready for landing. I will check efl ews and buildbots as soon as those patches are landed.

Comment on attachment 196460 [details] Patch Attachment 196460 [details] did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/17469293

Comment on attachment 196460 [details] Patch Clearing flags on attachment: 196460 Committed r148506: <http://trac.webkit.org/changeset/148506>

All reviewed patches have been landed. Closing bug.

The commit-queue encountered the following flaky tests while processing attachment 196460 [details]: media/video-played-collapse.html bug 58630 (authors: annacc@chromium.org, jamesr@chromium.org, pnormand@igalia.com, and vrk@chromium.org) media/track/track-mode.html bug 114361 (author: annacc@chromium.org) media/video-played-ranges-1.html bug 114675 (authors: annacc@chromium.org, hclam@google.com, jamesr@chromium.org, and vrk@chromium.org) transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org) transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com) transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org) transitions/multiple-shadow-transitions.html bug 114187 (author: simon.fraser@apple.com) transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com) transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com) transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org) transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com) transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com) transitions/flex-transitions.html bug 114195 (author: tony@chromium.org) transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org) transitions/multiple-mask-transitions.html bug 114197 (author: simon.fraser@apple.com) transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com) transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com) transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org) transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com) transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org and simon.fraser@apple.com) transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org) transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org) transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com) http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org) fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org) platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org) The commit-queue is continuing to process your patch.