Bug 117416

Created attachment 204180 [details] Patch

Comment on attachment 204180 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204180&action=review > Source/WebKit2/ChangeLog:26 > + While doing a strict build, with ENABLE_WERROR enabled, gcc complained > + about some enumeration values not being handled in two switch statements, > + causing the build to fail: > + > + CoordinatedGraphicsArgumentCoders.cpp:171:24: error: enumeration value > + 'COLOR' not handled in switch [-Werror=switch] > + CoordinatedGraphicsArgumentCoders.cpp:171:24: error: enumeration value > + 'MATRIX' not handled in switch [-Werror=switch] > + > + and > + > + CoordinatedGraphicsArgumentCoders.cpp:288:24: error: enumeration value > + 'COLOR' not handled in switch [-Werror=switch] > + CoordinatedGraphicsArgumentCoders.cpp:288:24: error: enumeration value > + 'MATRIX' not handled in switch [-Werror=switch] > + cc1plus: all warnings being treated as errors > + > + This patch adds a default case for each of these switches, to stop gcc > + from complaining and breaking a strict build. Too much information, simply say that you fix strict build by asserting on default switch cases or something like that :)

(In reply to comment #2) > (From update of attachment 204180 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204180&action=review [snip] > Too much information, simply say that you fix strict build by asserting on default switch cases or something like that :) Heh, okay :)

Created attachment 204183 [details] Patch

Comment on attachment 204183 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204183&action=review > Source/WebKit2/ChangeLog:8 > + This patch fix a strict build by asserting on the default case of two switch nit: fix -> fixes :)

Created attachment 204185 [details] Patch Fixed typo in changelog.

The commit-queue encountered the following flaky tests while processing attachment 204185 [details]: http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html bug 114208 (authors: abarth@webkit.org and rniwa@webkit.org) http/tests/inspector/inspect-element.html bug 78869 (author: pfeldman@chromium.org) media/video-poster-delayed.html bug 117426 (authors: annacc@chromium.org, jamesr@chromium.org, vestbo@webkit.org, and vrk@chromium.org) fast/loader/javascript-url-in-object.html bug 114210 (authors: rniwa@webkit.org and sam@webkit.org) platform/mac/editing/deleting/deletionUI-single-instance.html bug 114181 (author: rniwa@webkit.org) compositing/reflections/load-video-in-reflection.html bug 117427 (authors: mihaip@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) transitions/color-transition-rounding.html bug 114182 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-svg-length.html bug 114183 (author: peter@chromium.org) transitions/interrupt-zero-duration.html bug 114184 (authors: cmarrin@apple.com, rniwa@webkit.org, and simon.fraser@apple.com) transitions/multiple-background-transitions.html bug 114185 (author: simon.fraser@apple.com) transitions/cubic-bezier-overflow-color.html bug 114186 (author: peter@chromium.org) transitions/multiple-shadow-transitions.html bug 114187 (author: simon.fraser@apple.com) transitions/mismatched-shadow-transitions.html bug 114188 (author: simon.fraser@apple.com) transitions/color-transition-all.html bug 114189 (authors: ossy@webkit.org and simon.fraser@apple.com) transitions/cubic-bezier-overflow-shadow.html bug 114191 (author: peter@chromium.org) transitions/min-max-width-height-transitions.html bug 114192 (author: simon.fraser@apple.com) transitions/cancel-transition.html bug 114193 (authors: ojan@chromium.org, rniwa@webkit.org, and simon.fraser@apple.com) transitions/border-radius-transition.html bug 114194 (author: simon.fraser@apple.com) transitions/flex-transitions.html bug 114195 (author: tony@chromium.org) transitions/mixed-type.html bug 114196 (author: mikelawther@chromium.org) transitions/multiple-mask-transitions.html bug 114197 (author: simon.fraser@apple.com) transitions/color-transition-premultiplied.html bug 114198 (author: simon.fraser@apple.com) transitions/mismatched-shadow-styles.html bug 114199 (author: simon.fraser@apple.com) transitions/mask-transitions.html bug 114200 (authors: ojan@chromium.org, oliver@apple.com, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-length.html bug 114201 (author: peter@chromium.org) transitions/multiple-background-size-transitions.html bug 114202 (authors: mitz@webkit.org and simon.fraser@apple.com) transitions/clip-transition.html bug 114203 (authors: dglazkov@chromium.org, krit@webkit.org, and simon.fraser@apple.com) transitions/cubic-bezier-overflow-transform.html bug 114204 (author: peter@chromium.org) transitions/interrupted-accelerated-transition.html bug 56242 (authors: rniwa@webkit.org, simon.fraser@apple.com, and tonyg@chromium.org) transitions/background-transitions.html bug 114206 (author: simon.fraser@apple.com) The commit-queue is continuing to process your patch.

Comment on attachment 204185 [details] Patch Clearing flags on attachment: 204185 Committed r151406: <http://trac.webkit.org/changeset/151406>

All reviewed patches have been landed. Closing bug.