Bug 120155

Summary: Introduce a SVGUnknownElement class for unknown SVG elements
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: SVGAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, d-r, esprehn+autocc, fmalita, kangil.han, kling, krit, pdr, rwlbuis, schenney, zimmermann
Priority: P2 Keywords: BlinkMergeCandidate
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 107386    
Attachments:
Description Flags
Patch
kling: review+
Patch for landing none

Chris Dumez
Reported 2013-08-22 04:21:26 PDT
Introduce a SVGUnknownElement class and have it override rendererIsNeeded() to return false. We now use SVGUnknownElement type (instead of SVGElement) for unknown SVG elements: - Unknown Elements in SVG namespace - Registered custom tag elements in SVG namespace (http://www.w3.org/TR/2013/WD-custom-elements-20130514/#registering-custom-elements) As a consequence, SVGElement::rendererIsNeeded() is not longer required to return false and it will be able to behave as SVGStyledElement::rendererIsNeeded() once we merge SVGStyledElement into SVGElement. This is a pre-requirement to merging SVGStyledElement into SVGElement (Bug 107386). Corresponding Blink revision: https://src.chromium.org/viewvc/blink?revision=155426&view=revision
Attachments
Patch (14.16 KB, patch)
2013-08-22 04:55 PDT, Chris Dumez 		kling: review+
DetailsFormatted DiffDiff
Patch for landing (13.42 KB, patch)
2013-08-22 05:07 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-08-22 04:55:20 PDT
Created attachment 209347 [details] Patch
Andreas Kling
Comment 2 2013-08-22 04:57:39 PDT
Comment on attachment 209347 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209347&action=review r=me > Source/WebCore/svg/SVGUnknownElement.h:41 > +class SVGUnknownElement : public SVGElement { This class should be FINAL since it has no subclasses.
Chris Dumez
Comment 3 2013-08-22 05:07:38 PDT
Created attachment 209349 [details] Patch for landing Made the class FINAL.
WebKit Commit Bot
Comment 4 2013-08-22 05:37:17 PDT
Comment on attachment 209349 [details] Patch for landing Clearing flags on attachment: 209349 Committed r154443: <http://trac.webkit.org/changeset/154443>
WebKit Commit Bot
Comment 5 2013-08-22 05:37:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.