Bug 151611

Summary: [ARMv7] Some JSC test fails due to exhausting the JIT code heap on the no LLINT test configuration.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, keith_miller, mark.lam, msaboff, ossy, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 154392    
Bug Blocks: 108645    
Attachments:
Description Flags
proposed patch. none

Mark Lam
Reported 2015-11-25 13:26:20 PST
The following JSC stress test failures have been introduced recently: jsc-layout-tests.yaml/js/script-tests/dfg-osr-entry-hoisted-clobbered-structure-check.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/regress-141098.js.layout-no-llint I saw this when I tested with r192767.
Attachments
proposed patch. (7.02 KB, patch)
2016-02-15 20:26 PST, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-11-30 12:16:27 PST
<rdar://problem/23692532>
Mark Lam
Comment 2 2016-02-15 14:48:31 PST
With r196590, the following tests are also now failing: jsc-layout-tests.yaml/js/script-tests/dfg-float32array.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/dfg-float64array.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/dfg-int16array.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/dfg-int32array-overflow-values.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/dfg-int32array.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/dfg-int8array.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/dfg-uint16array.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/dfg-uint32array-overflow-values.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/dfg-uint32array.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/dfg-uint8array.js.layout-no-llint jsc-layout-tests.yaml/js/script-tests/dfg-uint8clampedarray.js.layout-no-llint All of these tests are failing on the no LLINT configuration.
Mark Lam
Comment 3 2016-02-15 16:05:49 PST
AFAICT, these tests are only failing because they are compiling too much with the LLINT disabled. As a result, they are using more JIT code heap space than is allowed by the OS. I'm looking into excluding these tests on the noLLINT configuration on ARMv7.
Mark Lam
Comment 4 2016-02-15 20:26:02 PST
Created attachment 271408 [details] proposed patch.
Mark Lam
Comment 5 2016-02-15 20:27:22 PST
I've verified that this patch only excludes the noLLInt configuration on 32-bit arm. It still runs that configuration on arm64.
WebKit Commit Bot
Comment 6 2016-02-15 23:10:10 PST
Comment on attachment 271408 [details] proposed patch. Clearing flags on attachment: 271408 Committed r196625: <http://trac.webkit.org/changeset/196625>
WebKit Commit Bot
Comment 7 2016-02-15 23:10:15 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.