Bug 152774

Summary: Support the ScrollOptions argument to programmatic scrolling APIs
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: DOMAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED WORKSFORME    
Severity: Normal CC: buildbot, cdumez, cmarcelo, commit-queue, dino, dvpdiner2, eoconnor, esprehn+autocc, glenn, jonlee, kangil.han, kondapallykalyan, rniwa, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar, WebExposed
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
URL: https://drafts.csswg.org/cssom-view/
Bug Depends on: 161610    
Bug Blocks:    
Attachments:
Description Flags
WIP
buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-yosemite
none
Archive of layout-test-results from ews107 for mac-yosemite-wk2
none
Archive of layout-test-results from ews117 for mac-yosemite none

Simon Fraser (smfr)
Reported 2016-01-05 22:02:45 PST
WebKit should support the ScrollOptions dictionary described in https://drafts.csswg.org/cssom-view/#scrolling This involves new API on Element, processing the ScrollOptions, and triggering smooth scrolling.
Attachments
WIP (22.92 KB, patch)
2016-01-06 09:52 PST, Simon Fraser (smfr) 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews101 for mac-yosemite (745.11 KB, application/zip)
2016-01-06 11:39 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews107 for mac-yosemite-wk2 (935.98 KB, application/zip)
2016-01-06 11:43 PST, Build Bot 		no flags
Details
Archive of layout-test-results from ews117 for mac-yosemite (800.31 KB, application/zip)
2016-01-06 11:49 PST, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2016-01-06 09:52:06 PST
Created attachment 268373 [details] WIP
WebKit Commit Bot
Comment 2 2016-01-06 10:43:15 PST
Attachment 268373 [details] did not pass style-queue: ERROR: Source/WebCore/page/DOMWindow.cpp:41: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 2 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2016-01-06 11:39:29 PST
Comment on attachment 268373 [details] WIP Attachment 268373 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/658417 New failing tests: fast/dom/Window/window-scroll-arguments.html
Build Bot
Comment 4 2016-01-06 11:39:34 PST
Created attachment 268381 [details] Archive of layout-test-results from ews101 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 5 2016-01-06 11:43:03 PST
Comment on attachment 268373 [details] WIP Attachment 268373 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/658419 New failing tests: fast/dom/Window/window-scroll-arguments.html
Build Bot
Comment 6 2016-01-06 11:43:09 PST
Created attachment 268382 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 7 2016-01-06 11:49:09 PST
Comment on attachment 268373 [details] WIP Attachment 268373 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/658428 New failing tests: fast/dom/Window/window-scroll-arguments.html
Build Bot
Comment 8 2016-01-06 11:49:14 PST
Created attachment 268383 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Simon Fraser (smfr)
Comment 9 2016-01-06 21:35:36 PST
WebKit currently supports window.scrollTo() with one argument. We need to make scrollTo(<number>) throw, and require that the single-argument version is getting an Object argument (as FF and Blink do). Not sure how do that in IDL.
Sam Weinig
Comment 10 2016-01-07 12:31:25 PST
(In reply to comment #9) > WebKit currently supports window.scrollTo() with one argument. We need to > make scrollTo(<number>) throw, and require that the single-argument version > is getting an Object argument (as FF and Blink do). Not sure how do that in > IDL. Probably something like this: void scrollTo(long x, long y); void scrollTo(optional Dictionary options); Though, we may want to change to "unrestricted double" as well.
Simon Fraser (smfr)
Comment 11 2016-01-07 12:57:51 PST
This also shows that there's some combat risk with this change, but since Chrome and FF both agree on the new behavior, it's probably low.
Radar WebKit Bug Importer
Comment 12 2016-01-07 20:42:19 PST
<rdar://problem/24102997>
Simon Fraser (smfr)
Comment 13 2016-12-02 13:57:39 PST
This has been implemented via bindings changes etc.
Note You need to log in before you can comment on or make changes to this bug.