Bug 158060

Summary: [css-grid] Turn on ENABLE_CSS_GRID_LAYOUT by default
Product: WebKit Reporter: Manuel Rego Casasnovas <rego>
Component: New BugsAssignee: Manuel Rego Casasnovas <rego>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, commit-queue, gyuyoung.kim, jfernandez, jh718.park, mcatanzaro, ossy, rego, svillar
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 60731    
Attachments:
Description Flags
Patch none

Manuel Rego Casasnovas
Reported 2016-05-25 00:18:28 PDT
[css-grid] Turn on ENABLE_CSS_GRID_LAYOUT by default
Attachments
Patch (1.80 KB, patch)
2016-05-25 00:21 PDT, Manuel Rego Casasnovas 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Manuel Rego Casasnovas
Comment 1 2016-05-25 00:21:08 PDT
Created attachment 279746 [details] Patch As @mcatanzaro suggested on bug #157391, I'm enabling CSS Grid Layout build flag by default.
Darin Adler
Comment 2 2016-05-25 03:32:15 PDT
Comment on attachment 279746 [details] Patch This only affects platforms using CMake. Is this already correct on Mac and iOS?
Csaba Osztrogonác
Comment 3 2016-05-25 05:36:58 PDT
(In reply to comment #2) > Comment on attachment 279746 [details] > Patch > > This only affects platforms using CMake. Is this already correct on Mac and > iOS? It is already enabled in FeatureDefines.xcconfig files. What about the EFL port? Don't you guys want to enable this feature? It seems EFL port is the last one disabling CSS Grid Layout.
Csaba Osztrogonác
Comment 4 2016-05-25 05:38:22 PDT
Ah, I was wrong, it is already enabled on EFL too because of FeatureList.pm. But in this case there is no reason to disable it in cmake.
Darin Adler
Comment 5 2016-05-25 09:22:14 PDT
Comment on attachment 279746 [details] Patch OK.
WebKit Commit Bot
Comment 6 2016-05-25 12:38:37 PDT
Comment on attachment 279746 [details] Patch Clearing flags on attachment: 279746 Committed r201396: <http://trac.webkit.org/changeset/201396>
WebKit Commit Bot
Comment 7 2016-05-25 12:38:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.