Bug 158657

Summary: Web Inspector: Show Exception Stack in UncaughtExceptionReporter view
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 55092    
Bug Blocks:    
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[IMAGE] UncaughtExceptionView with stack
none
[PATCH] Proposed Fix
none
[IMAGE] Exception Stack none

Joseph Pecoraro
Reported 2016-06-11 01:25:57 PDT
Summary: Show Exception Stack in UncaughtExceptionReporter view Not just the location, but the full stack when possible. Requires bug 55092 so window.onerror includes the Error + potential stack with it.
Attachments
[PATCH] Proposed Fix (3.62 KB, patch)
2016-06-11 01:27 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[IMAGE] UncaughtExceptionView with stack (161.14 KB, image/png)
2016-06-11 01:27 PDT, Joseph Pecoraro 		no flags
Details
[PATCH] Proposed Fix (3.64 KB, patch)
2016-06-11 01:30 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[IMAGE] Exception Stack (155.78 KB, image/png)
2016-06-11 01:31 PDT, Joseph Pecoraro 		no flags
Details
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-06-11 01:26:23 PDT
<rdar://problem/26754441>
Joseph Pecoraro
Comment 2 2016-06-11 01:27:12 PDT
Created attachment 281086 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2016-06-11 01:27:35 PDT
Created attachment 281087 [details] [IMAGE] UncaughtExceptionView with stack
Joseph Pecoraro
Comment 4 2016-06-11 01:28:54 PDT
Comment on attachment 281086 [details] [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=281086&action=review > Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js:162 > + let slashIndex = line.lastIndexOf("/"); Oops, I should clearly handle when there isn't a '/' in the path (e.g. the [native code] examples in the screenshot).
Joseph Pecoraro
Comment 5 2016-06-11 01:30:50 PDT
Created attachment 281088 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 6 2016-06-11 01:31:15 PDT
Created attachment 281089 [details] [IMAGE] Exception Stack
WebKit Commit Bot
Comment 7 2016-06-13 21:31:30 PDT
Comment on attachment 281088 [details] [PATCH] Proposed Fix Clearing flags on attachment: 281088 Committed r202025: <http://trac.webkit.org/changeset/202025>
WebKit Commit Bot
Comment 8 2016-06-13 21:31:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.