Bug 160245

Summary: Introduce a RenderMathMLFencedOperator class
Product: WebKit Reporter: Frédéric Wang (:fredw) <fred.wang>
Component: MathMLAssignee: Frédéric Wang (:fredw) <fred.wang>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, bfulgham, jfernandez, rego
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 160241    
Bug Blocks: 160396, 156537    
Attachments:
Description Flags
Patch (applies after bug 160241)
none
Patch
none
Patch darin: review+

Frédéric Wang (:fredw)
Reported 2016-07-27 07:13:05 PDT
Another step towards bug 156537. This class will handle all the code specific to (anonymous) mfenced operators. In particular many members of the RenderMathMLOperator class are going to be removed while fixing bug 156537 but they may still need to stored and exposed in some way by mfenced operators. This work applies after bug 160241 and the new class will first be used to expose the m_textContent and update it.
Attachments
Patch (applies after bug 160241) (22.52 KB, patch)
2016-07-27 07:27 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (21.97 KB, patch)
2016-07-29 00:39 PDT, Frédéric Wang (:fredw) 		no flags
DetailsFormatted DiffDiff
Patch (23.21 KB, patch)
2016-07-29 02:10 PDT, Frédéric Wang (:fredw) 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Frédéric Wang (:fredw)
Comment 1 2016-07-27 07:27:42 PDT
Created attachment 284694 [details] Patch (applies after bug 160241)
Frédéric Wang (:fredw)
Comment 2 2016-07-29 00:39:26 PDT
Created attachment 284850 [details] Patch
Frédéric Wang (:fredw)
Comment 3 2016-07-29 02:10:10 PDT
Created attachment 284855 [details] Patch
Javier Fernandez
Comment 4 2016-07-29 07:51:09 PDT
Comment on attachment 284855 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284855&action=review > Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp:87 > +RenderPtr<RenderMathMLFencedOperator> RenderMathMLFenced::createMathMLOperator(const String& operatorString, MathMLOperatorDictionary::Form form, MathMLOperatorDictionary::Flag flag) Probably not a change to be don in this patch, but I wonder whether we should remove the RenderPtr and use std:unique instead.
Darin Adler
Comment 5 2016-07-31 21:35:42 PDT
Comment on attachment 284855 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284855&action=review > Source/WebCore/rendering/mathml/RenderMathMLFencedOperator.cpp:39 > + m_operatorForm = form; > + m_operatorFlags = flags; Can we pass these to a base class constructor instead of using assignment?
Frédéric Wang (:fredw)
Comment 6 2016-08-01 00:44:35 PDT
(In reply to comment #4) > Probably not a change to be don in this patch, but I wonder whether we > should remove the RenderPtr and use std:unique instead. Yes, I opened 160396. (In reply to comment #5) > Comment on attachment 284855 [details] > Can we pass these to a base class constructor instead of using assignment? OK. The plan is to move these members to the derived class later, but for now I'll keep initialization in the base class.
Frédéric Wang (:fredw)
Comment 7 2016-08-01 00:45:44 PDT
Committed r203973: <http://trac.webkit.org/changeset/203973>
Note You need to log in before you can comment on or make changes to this bug.