Bug 168822

Summary: WebAssembly: miscellaneous spec fixes
Product: WebKit Reporter: JF Bastien <jfbastien>
Component: JavaScriptCoreAssignee: JF Bastien <jfbastien>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, fpizlo, jfbastien, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 159775    
Attachments:
Description Flags
patch
none
Archive of layout-test-results from ews116 for mac-elcapitan none

JF Bastien
Reported 2017-02-23 22:57:03 PST
Trying to figure out remaining bugs is looking for a needle in a haystack. Let reduce the number of "skip" spec tests in the hope that it serves as a hay sifter and finds our needle.
Attachments
patch (28.21 KB, patch)
2017-02-23 23:03 PST, JF Bastien 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews116 for mac-elcapitan (1.54 MB, application/zip)
2017-02-24 00:19 PST, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
JF Bastien
Comment 1 2017-02-23 23:03:20 PST
Created attachment 302649 [details] patch I'll do the other tests in a follow-up patch.
Saam Barati
Comment 2 2017-02-23 23:42:49 PST
Comment on attachment 302649 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=302649&action=review > JSTests/wasm/spec-tests/imports.wast.js:59 > + if (e instanceof WebAssembly.LinkError) return; // Note: this is fixed in tip-of-tree wabt. Maybe a FIXME?
Build Bot
Comment 3 2017-02-24 00:19:36 PST
Comment on attachment 302649 [details] patch Attachment 302649 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3183686 New failing tests: media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html
Build Bot
Comment 4 2017-02-24 00:19:39 PST
Created attachment 302654 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
WebKit Commit Bot
Comment 5 2017-02-24 18:04:16 PST
Comment on attachment 302649 [details] patch Clearing flags on attachment: 302649 Committed r212983: <http://trac.webkit.org/changeset/212983>
WebKit Commit Bot
Comment 6 2017-02-24 18:05:00 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.