Bug 170242

Summary: WebAssembly: NFC s/goto/lambda/g
Product: WebKit Reporter: JF Bastien <jfbastien>
Component: JavaScriptCoreAssignee: JF Bastien <jfbastien>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, jfbastien, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 170219    
Bug Blocks:    
Attachments:
Description Flags
patch
mark.lam: review+
patch
mark.lam: review+, jfbastien: commit-queue+
patch none

JF Bastien
Reported 2017-03-29 09:03:52 PDT
As suggested in https://bugs.webkit.org/show_bug.cgi?id=170219, my early-2000 C++ skillz should be updated to "post-modern C++". `goto fail` isn't as nice as lambdas.
Attachments
patch (2.77 KB, patch)
2017-03-29 09:07 PDT, JF Bastien 		mark.lam: review+
DetailsFormatted DiffDiff
patch (2.77 KB, patch)
2017-03-29 09:22 PDT, JF Bastien 		mark.lam: review+
jfbastien: commit-queue+
DetailsFormatted DiffDiff
patch (2.76 KB, patch)
2017-03-29 10:02 PDT, JF Bastien 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
JF Bastien
Comment 1 2017-03-29 09:07:30 PDT
Created attachment 305740 [details] patch goto lambda;
Mark Lam
Comment 2 2017-03-29 09:17:01 PDT
Comment on attachment 305740 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=305740&action=review r=me with suggested fix. > Source/JavaScriptCore/wasm/WasmMemory.cpp:121 > + auto fail = [&] () -> bool { This does not need to be a [&] lambda, right? Just [] should do.
JF Bastien
Comment 3 2017-03-29 09:22:09 PDT
Created attachment 305746 [details] patch No need to capture in lambda.
JF Bastien
Comment 4 2017-03-29 10:02:21 PDT
Created attachment 305751 [details] patch Forgot to update reviewer.
WebKit Commit Bot
Comment 5 2017-03-29 10:17:52 PDT
Comment on attachment 305751 [details] patch Clearing flags on attachment: 305751 Committed r214541: <http://trac.webkit.org/changeset/214541>
WebKit Commit Bot
Comment 6 2017-03-29 10:17:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.