Bug 170261

Summary: WebAssembly: Make our calls out to JS PIC friendly
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, fpizlo, ggaren, gskachkov, jfbastien, keith_miller, mark.lam, msaboff, ticaiolima, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 168264    
Attachments:
Description Flags
patch none

Saam Barati
Reported 2017-03-29 17:22:07 PDT
...
Attachments
patch (13.26 KB, patch)
2017-03-31 18:12 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Saam Barati
Comment 1 2017-03-31 16:13:08 PDT
Working on this now.
Saam Barati
Comment 2 2017-03-31 18:12:33 PDT
Created attachment 306034 [details] patch
Keith Miller
Comment 3 2017-03-31 18:27:51 PDT
Comment on attachment 306034 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=306034&action=review r=me. > Source/JavaScriptCore/wasm/js/JSWebAssemblyCodeBlock.h:120 > + static ptrdiff_t offsetOfImportWasmToJSStub(unsigned calleeCount, unsigned importIndex) > + { > + return offsetOfCallees() > + + (sizeof(WriteBarrier<JSWebAssemblyCallee>) * calleeCount * 2) > + + (sizeof(void*) * importIndex); > + } > + oh man, this is brutal.
Saam Barati
Comment 4 2017-03-31 18:32:15 PDT
Comment on attachment 306034 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=306034&action=review >> Source/JavaScriptCore/wasm/js/JSWebAssemblyCodeBlock.h:120 >> + > > oh man, this is brutal. Glorious object layout 🎉
WebKit Commit Bot
Comment 5 2017-03-31 19:09:55 PDT
Comment on attachment 306034 [details] patch Clearing flags on attachment: 306034 Committed r214711: <http://trac.webkit.org/changeset/214711>
WebKit Commit Bot
Comment 6 2017-03-31 19:09:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.