Bug 170958

Summary: wasm/function-tests/memory-multiagent times out sometimes
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: jfbastien, keith_miller
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch to skip the test for now keith_miller: review+

Filip Pizlo
Reported 2017-04-18 11:41:33 PDT
...
Attachments
patch to skip the test for now (2.45 KB, patch)
2017-04-18 11:42 PDT, Filip Pizlo 		keith_miller: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2017-04-18 11:42:57 PDT
Created attachment 307399 [details] patch to skip the test for now
Keith Miller
Comment 2 2017-04-18 11:48:40 PDT
Comment on attachment 307399 [details] patch to skip the test for now r=me.
Keith Miller
Comment 3 2017-04-18 11:48:57 PDT
Comment on attachment 307399 [details] patch to skip the test for now View in context: https://bugs.webkit.org/attachment.cgi?id=307399&action=review > JSTests/wasm/function-tests/memory-multiagent.js:51 > + // prevents any JS-heap-modifying things from happening because JS is a synchrinous typo: synchronous
Filip Pizlo
Comment 4 2017-04-18 11:50:16 PDT
(In reply to Keith Miller from comment #3) > Comment on attachment 307399 [details] > patch to skip the test for now > > View in context: > https://bugs.webkit.org/attachment.cgi?id=307399&action=review > > > JSTests/wasm/function-tests/memory-multiagent.js:51 > > + // prevents any JS-heap-modifying things from happening because JS is a synchrinous > > typo: synchronous Fixed!
Filip Pizlo
Comment 5 2017-04-18 12:28:47 PDT
Landed in https://trac.webkit.org/changeset/215475/webkit
JF Bastien
Comment 6 2017-04-18 13:13:51 PDT
Comment on attachment 307399 [details] patch to skip the test for now View in context: https://bugs.webkit.org/attachment.cgi?id=307399&action=review > JSTests/wasm/function-tests/memory-multiagent.js:53 > + // https://bugs.webkit.org/show_bug.cgi?id=170958 My expectation was that receiveBroadcast could change the value of `state`. Is that not the case?
Filip Pizlo
Comment 7 2017-04-18 13:16:47 PDT
(In reply to JF Bastien from comment #6) > Comment on attachment 307399 [details] > patch to skip the test for now > > View in context: > https://bugs.webkit.org/attachment.cgi?id=307399&action=review > > > JSTests/wasm/function-tests/memory-multiagent.js:53 > > + // https://bugs.webkit.org/show_bug.cgi?id=170958 > > My expectation was that receiveBroadcast could change the value of `state`. > Is that not the case? It could. But how would it run? JS is runloop-based. You're doing a while loop. So the runloop doesn't run.
JF Bastien
Comment 8 2017-04-18 13:19:52 PDT
(In reply to Filip Pizlo from comment #7) > (In reply to JF Bastien from comment #6) > > Comment on attachment 307399 [details] > > patch to skip the test for now > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=307399&action=review > > > > > JSTests/wasm/function-tests/memory-multiagent.js:53 > > > + // https://bugs.webkit.org/show_bug.cgi?id=170958 > > > > My expectation was that receiveBroadcast could change the value of `state`. > > Is that not the case? > > It could. But how would it run? JS is runloop-based. You're doing a while > loop. So the runloop doesn't run. Seemed to work in the jsc shell. I'll do a follow-up soon.
Note You need to log in before you can comment on or make changes to this bug.