Bug 172341

Summary: Speedometer 2.0: jQuery and Inferno tests don't delete all ToDo items
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: addyo, cdumez, commit-queue, ggaren, koivisto, lforschler, saam
Priority: P2    
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 172339    
Attachments:
Description Flags
Fixes the bug
none
Added missing changes to InteractiveRunner.html none

Ryosuke Niwa
Reported 2017-05-18 22:09:19 PDT
There is a bug in the benchmark code and not all ToDo items are deleted in jQuery and inferno tests.
Attachments
Fixes the bug (3.90 KB, patch)
2017-05-18 22:14 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Added missing changes to InteractiveRunner.html (4.71 KB, patch)
2017-05-18 22:18 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-05-18 22:14:19 PDT
Created attachment 310614 [details] Fixes the bug
Ryosuke Niwa
Comment 2 2017-05-18 22:18:40 PDT
Created attachment 310615 [details] Added missing changes to InteractiveRunner.html
Antti Koivisto
Comment 3 2017-05-19 02:02:24 PDT
Comment on attachment 310615 [details] Added missing changes to InteractiveRunner.html View in context: https://bugs.webkit.org/attachment.cgi?id=310615&action=review > PerformanceTests/Speedometer/resources/tests.js:343 > - var checkboxes = contentDocument.querySelectorAll('.toggle'); > + var checkboxes = contentDocument.getElementsByClassName('toggle'); Why the switch? You mostly use querySelector.
Ryosuke Niwa
Comment 4 2017-05-19 02:17:48 PDT
Comment on attachment 310615 [details] Added missing changes to InteractiveRunner.html View in context: https://bugs.webkit.org/attachment.cgi?id=310615&action=review >> PerformanceTests/Speedometer/resources/tests.js:343 >> + var checkboxes = contentDocument.getElementsByClassName('toggle'); > > Why the switch? You mostly use querySelector. We have to get i-th element in the node list instead of the first. So the alternative is to run querySelectorAll and get i-th element. That's a lot less efficient.
WebKit Commit Bot
Comment 5 2017-05-19 02:43:43 PDT
Comment on attachment 310615 [details] Added missing changes to InteractiveRunner.html Clearing flags on attachment: 310615 Committed r217112: <http://trac.webkit.org/changeset/217112>
WebKit Commit Bot
Comment 6 2017-05-19 02:43:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.