Bug 175284

Summary: Web Inspector: allow recordings to be saved via ⌘-S in the Recording tab
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, inspector-bugzilla-changes, joepeck, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 174484    
Bug Blocks: 173807    
Attachments:
Description Flags
Patch
none
Patch none

Devin Rousso
Reported 2017-08-07 13:23:04 PDT
.
Attachments
Patch (1.65 KB, patch)
2017-08-07 14:03 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (3.03 KB, patch)
2017-08-21 22:03 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2017-08-07 14:03:50 PDT
Created attachment 317461 [details] Patch
Matt Baker
Comment 2 2017-08-11 20:07:52 PDT
Comment on attachment 317461 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317461&action=review r-, since this duplicates code in RecordingNavigationSidebarPanel. The sidebar should probably be using the new `saveData()` getter. > Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js:99 > + forceSaveAs: true, What are your thoughts on versioning?
Devin Rousso
Comment 3 2017-08-17 19:11:57 PDT
(In reply to Matt Baker from comment #2) > Comment on attachment 317461 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=317461&action=review > > r-, since this duplicates code in RecordingNavigationSidebarPanel. The > sidebar should probably be using the new `saveData()` getter. > > > Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js:99 > > + forceSaveAs: true, > > What are your thoughts on versioning? We already have a version in the Recording protocol. I'm not sure what you mean otherwise.
Devin Rousso
Comment 4 2017-08-21 22:03:42 PDT
Created attachment 318736 [details] Patch
Radar WebKit Bug Importer
Comment 5 2017-08-23 12:11:53 PDT
<rdar://problem/34040758>
Matt Baker
Comment 6 2017-09-13 17:02:53 PDT
Comment on attachment 318736 [details] Patch r=me
WebKit Commit Bot
Comment 7 2017-09-13 17:32:07 PDT
Comment on attachment 318736 [details] Patch Clearing flags on attachment: 318736 Committed r222003: <http://trac.webkit.org/changeset/222003>
WebKit Commit Bot
Comment 8 2017-09-13 17:32:08 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 9 2017-09-13 19:32:18 PDT
Comment on attachment 318736 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318736&action=review > Source/WebInspectorUI/UserInterface/Views/RecordingNavigationSidebarPanel.js:171 > + WI.saveDataToFile(this.contentBrowser.currentContentView.saveData, forceSaveAs); The saveData already has `forceSaveAs: true`. I suppose its fine to be explicit here, but this means that no matter what ContentView eventually shows up in the Recording tab will always be a forceSaveAs even if the ContentView logically can re-save. I don't think that ever be likely to happen though.
Note You need to log in before you can comment on or make changes to this bug.