Bug 175448

Summary:

Web Inspector: add filter for draw actions in Recordings

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

agomez, bburg, buildbot, commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

174484

Bug Blocks:

173807

Attachments:

Description	Flags
Patch	none
[Image] After Patch is applied	none

Devin Rousso

Reported 2017-08-10 15:08:18 PDT

We are already able to filter by name, but we currently can't filter by "designation"/"category". Filtering by whether the action draws would be great. This could be done similar to how Debugger has "Only show resources with issues".

Attachments
Patch (10.21 KB, patch) 2017-08-23 14:43 PDT, Devin Rousso	no flags	Details Formatted Diff Diff
[Image] After Patch is applied (359.67 KB, image/png) 2017-08-23 14:44 PDT, Devin Rousso	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-08-23 12:12:13 PDT

<rdar://problem/34040764>

Devin Rousso

Comment 2 2017-08-23 14:43:46 PDT

Created attachment 318923 [details] Patch

Devin Rousso

Comment 3 2017-08-23 14:44:12 PDT

Created attachment 318924 [details] [Image] After Patch is applied

Matt Baker

Comment 4 2017-08-23 15:33:45 PDT

We should remove the visual change highlight when the filter is active.

Devin Rousso

Comment 5 2017-08-23 15:45:43 PDT

(In reply to Matt Baker from comment #4) > We should remove the visual change highlight when the filter is active. I think that would be more confusing. I would expect filtering to just show/hide, not change any shown UI.

Matt Baker

Comment 6 2017-08-24 15:19:48 PDT

Comment on attachment 318923 [details] Patch r=me, just need to figure out what's causing the build failure on wpe.

Matt Baker

Comment 7 2017-08-24 16:27:30 PDT

The problem is with the way WPE handles dependencies. WebKit/PlatformWPE.cmake:435: set(InspectorFiles ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/*.html ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Base/*.js ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Controllers/*.css ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Controllers/*.js ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Debug/*.css ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Debug/*.js ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/External/CodeMirror/*.css ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/External/CodeMirror/*.js ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/External/ESLint/*.js ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/External/Esprima/*.js ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Images/gtk/*.png ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Images/gtk/*.svg ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Models/*.js ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Protocol/*.js ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Proxies/*.js ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Test/*.js ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Views/*.css ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Views/*.js ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Workers/Formatter/*.js ${CMAKE_SOURCE_DIR}/Source/WebInspectorUI/UserInterface/Workers/HeapSnapshot/*.js ) file(GLOB InspectorFilesDependencies ${InspectorFiles} ) InspectorGResourceBundle.xml is only regenerated when CMake runs, which will be never, since CMakeLists.txt isn't changing. WPE will break whenever an Inspector file is renamed, and won't pick up newly added files either.

Matt Baker

Comment 8 2017-08-24 17:28:16 PDT

This is a known issue, and I've contacted a couple of WPE maintainers to remind them. Since this just effects EWS, no need to wait for a resolution.

WebKit Commit Bot

Comment 9 2017-08-24 17:57:45 PDT

Comment on attachment 318923 [details] Patch Clearing flags on attachment: 318923 Committed r221174: <http://trac.webkit.org/changeset/221174>

WebKit Commit Bot

Comment 10 2017-08-24 17:57:46 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.