Bug 175811

Summary: Speedometer 2.0: Make it possible to change the iteration count via query string
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, fpizlo, ggaren, keith_miller, lforschler, mathias, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 172339    
Attachments:
Description Flags
Patch saam: review+

Ryosuke Niwa
Reported 2017-08-21 22:06:47 PDT
Make it possible to change the iteration count of Speedometer via query string. Also reduce the default iteration count from 20 to 10.
Attachments
Patch (3.67 KB, patch)
2017-08-21 23:00 PDT, Ryosuke Niwa 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-08-21 23:00:02 PDT
Created attachment 318738 [details] Patch
Mathias Bynens
Comment 2 2017-08-22 04:32:30 PDT
Comment on attachment 318738 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318738&action=review > PerformanceTests/Speedometer/resources/main.js:154 > + var parts = location.search.substring(1).split('&'); Shame Edge doesn’t support `URLSearchParams` yet — that would simplify this section greatly! > PerformanceTests/Speedometer/resources/main.js:171 > + console.error('Invalid iteratin count: ' + value); typo: iteration
Saam Barati
Comment 3 2017-08-22 05:00:49 PDT
Comment on attachment 318738 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=318738&action=review > PerformanceTests/Speedometer/resources/main.js:160 > + case 'unit': Why have this parameter if only “ms” is allowed? > PerformanceTests/Speedometer/resources/main.js:168 > + if (!isNaN(value)) Should be isNaN(parsedValue)
Ryosuke Niwa
Comment 4 2017-08-22 13:58:42 PDT
(In reply to Saam Barati from comment #3) > Comment on attachment 318738 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318738&action=review > > > PerformanceTests/Speedometer/resources/main.js:160 > > + case 'unit': > > Why have this parameter if only “ms” is allowed? Just for clarity. ?unit=ms reads better than ?ms. > > PerformanceTests/Speedometer/resources/main.js:168 > > + if (!isNaN(value)) > > Should be isNaN(parsedValue) Oops, fixed.
Ryosuke Niwa
Comment 5 2017-08-22 13:58:53 PDT
(In reply to Mathias Bynens from comment #2) > Comment on attachment 318738 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318738&action=review > > > PerformanceTests/Speedometer/resources/main.js:154 > > + var parts = location.search.substring(1).split('&'); > > Shame Edge doesn’t support `URLSearchParams` yet — that would simplify this > section greatly! > > > PerformanceTests/Speedometer/resources/main.js:171 > > + console.error('Invalid iteratin count: ' + value); > > typo: iteration Fixed.
Ryosuke Niwa
Comment 6 2017-08-22 14:00:51 PDT
Committed r221044: <http://trac.webkit.org/changeset/221044>
Radar WebKit Bug Importer
Comment 7 2017-08-22 14:02:04 PDT
<rdar://problem/34020863>
Note You need to log in before you can comment on or make changes to this bug.