Bug 175816

Summary: Speedometer 2.0: Add button to select and unselect all tests to InteractiveRunner.html
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: addyo, cdumez, ggaren, joepeck, keith_miller, lforschler, mathias, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 172339    
Attachments:
Description Flags
Adds the buttons
none
Removed superfluous newline saam: review+

Ryosuke Niwa
Reported 2017-08-22 01:02:14 PDT
Now that we have doubled the number of test cases in Speedometer, we should have buttons to quickly select & unselect all test cases.
Attachments
Adds the buttons (2.04 KB, patch)
2017-08-22 01:07 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Removed superfluous newline (1.84 KB, patch)
2017-08-22 01:08 PDT, Ryosuke Niwa 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-08-22 01:07:29 PDT
Created attachment 318745 [details] Adds the buttons
Ryosuke Niwa
Comment 2 2017-08-22 01:08:21 PDT
Created attachment 318746 [details] Removed superfluous newline
Saam Barati
Comment 3 2017-08-22 08:29:19 PDT
Comment on attachment 318746 [details] Removed superfluous newline View in context: https://bugs.webkit.org/attachment.cgi?id=318746&action=review r=me > PerformanceTests/Speedometer/InteractiveRunner.html:77 > + for (var suiteIndex = 0; suiteIndex < suites.length; suiteIndex++) { For of? > PerformanceTests/Speedometer/InteractiveRunner.html:87 > + for (var suiteIndex = 0; suiteIndex < suites.length; suiteIndex++) { Ditto
Ryosuke Niwa
Comment 4 2017-08-22 13:40:20 PDT
(In reply to Saam Barati from comment #3) > Comment on attachment 318746 [details] > Removed superfluous newline > > View in context: > https://bugs.webkit.org/attachment.cgi?id=318746&action=review > > r=me > > > PerformanceTests/Speedometer/InteractiveRunner.html:77 > > + for (var suiteIndex = 0; suiteIndex < suites.length; suiteIndex++) { > > For of? No, we don't want the runner code to require ES2015. We occasionally run the latest version of Speedometer in very old versions of Safari for validation purposes. See https://bugs.webkit.org/show_bug.cgi?id=172439 for example in which I ran trunk Speedometer on Safari 7. > > > PerformanceTests/Speedometer/InteractiveRunner.html:87 > > + for (var suiteIndex = 0; suiteIndex < suites.length; suiteIndex++) { > > Ditto Ditto.
Ryosuke Niwa
Comment 5 2017-08-22 13:42:26 PDT
Committed r221039: <http://trac.webkit.org/changeset/221039>
Radar WebKit Bug Importer
Comment 6 2017-08-22 13:43:34 PDT
<rdar://problem/34020295>
Note You need to log in before you can comment on or make changes to this bug.