Bug 175956

Summary: Speedometer 2.0: Duplicate the current EmberJS test as EmberJS-Debug test
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: addyo, buildbot, cdumez, fpizlo, ggaren, lforschler, mathias, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 172339, 175926    
Attachments:
Description Flags
Adds Ember-Debug-TodoMVC saam: review+

Ryosuke Niwa
Reported 2017-08-24 14:55:19 PDT
In https://bugs.webkit.org/show_bug.cgi?id=175926, we found out that we weren't testing release build of Ember, and that release build of Ember is 3.5x-4x faster than debug build of Ember on Chrome/Safari. When we decided to use a release build of Ember instead of a debug build, we thought the difference was negligible due to an incorrect measurements we made in the past where we were basically testing the same debug builds twice. Since 4x difference indicates a debug build of Ember has a very different performance characteristics compared to a release build, we should keep the current version as EmberJS-Debug test.
Attachments
Adds Ember-Debug-TodoMVC (2.56 KB, patch)
2017-08-24 14:58 PDT, Ryosuke Niwa 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-08-24 14:58:46 PDT
Created attachment 319023 [details] Adds Ember-Debug-TodoMVC
Ryosuke Niwa
Comment 2 2017-08-24 15:00:03 PDT
Somehow the patch doesn't show the files I'm copying presumably because I directly used svn cp. Note that this is the current version of the test we have for Ember so there is no need for qualifications, comparisons between browsers, etc...
Saam Barati
Comment 3 2017-08-24 16:13:45 PDT
Comment on attachment 319023 [details] Adds Ember-Debug-TodoMVC r=me
Ryosuke Niwa
Comment 4 2017-08-25 14:21:37 PDT
Committed r221205: <http://trac.webkit.org/changeset/221205>
Radar WebKit Bug Importer
Comment 5 2017-08-25 14:22:27 PDT
<rdar://problem/34088816>
Note You need to log in before you can comment on or make changes to this bug.