Bug 176355

Summary: Speedometer 2.0: Delete ToDo items in reversed order for Inferno suite
Product: WebKit Reporter: Shiyu Zhang <shiyu.zhang>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: addyo, lforschler, pan.deng, rniwa, tianyou.li
Priority: P2    
Version: WebKit Nightly Build   
Hardware: PC   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=172341
https://bugs.webkit.org/show_bug.cgi?id=176586
Bug Depends on:    
Bug Blocks: 172339    
Attachments:
Description Flags
Delete todo-items in reversed order for inferno suite none

Shiyu Zhang
Reported 2017-09-05 01:41:14 PDT
Created attachment 319886 [details] Delete todo-items in reversed order for inferno suite Inferno case shows a strange behavior when deleting items. The deleteButtons array will be dynamically updated once one todo-item is deleted. For example, after deleteButtons[i].click() executed, deleteButtons[i+1] was copied to deleteButtons[i], deleteButtons[i+2] was copied to deleteButtons[i+1] ... This behavior caused the bug of "don't delete all ToDo items" in https://bugs.webkit.org/show_bug.cgi?id=172341. I tried to delete items in reversed order for Inferno case as the patch did. All the todo-items can be deleted and the results on my PC (Ubuntu Chrome R60) showed 4x score improvement for Inferno case. I think it’s unusual to dynamically update deleteButtons array in the Inferno use case. Maybe we can walk around this by deleting items in reversed order for Inferno case.
Attachments
Delete todo-items in reversed order for inferno suite (727 bytes, patch)
2017-09-05 01:41 PDT, Shiyu Zhang
no flags
Ryosuke Niwa
Comment 1 2017-09-05 20:18:53 PDT
No, we don't want to make each test case faster like this. The whole point of this benchmark is to have browser engines optimize DOM API, not measure what they're already fast at.
Note You need to log in before you can comment on or make changes to this bug.