Bug 177359

Summary: Speedometer: Add missing build scripts for Vue.js example
Product: WebKit Reporter: Mathias Bynens <mathias>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: addyo, buildbot, cdumez, commit-queue, mathias, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 172339, 177358    
Attachments:
Description Flags
Patch
none
Results before and after applying the patch none

Mathias Bynens
Reported 2017-09-22 05:34:34 PDT
While looking into #177358 I noticed that the Vue.js example is missing the `build` folder. This directory contains the build scripts needed to update `dist/*`. It had not been checked in because previously, all `build` directories were ignored by `.gitignore`. An exception was recently added for the Speedometer directory, so now we can check it in. I’ll submit a patch.
Attachments
Patch (1.98 MB, patch)
2017-09-22 05:53 PDT, Mathias Bynens 		no flags
DetailsFormatted DiffDiff
Results before and after applying the patch (93.58 KB, application/pdf)
2017-09-24 23:31 PDT, Mathias Bynens 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Mathias Bynens
Comment 1 2017-09-22 05:53:23 PDT
Created attachment 321534 [details] Patch
Mathias Bynens
Comment 2 2017-09-22 05:54:15 PDT
Note that this patch fixes #177358 as well, but only for the Vue.js example. I’ll submit a separate patch that fixes the others.
Addy Osmani
Comment 3 2017-09-22 15:39:20 PDT
This should lead to a cleaner rebuild/update Vue implementation cycle in the future. Thanks for going ahead and submitting a patch for fixing the build.
Ryosuke Niwa
Comment 4 2017-09-22 15:58:38 PDT
Did you test to make sure scores don't change before/after the change?
Mathias Bynens
Comment 5 2017-09-24 23:31:36 PDT
Created attachment 321670 [details] Results before and after applying the patch
WebKit Commit Bot
Comment 6 2017-09-25 20:29:59 PDT
Comment on attachment 321534 [details] Patch Clearing flags on attachment: 321534 Committed r222488: <http://trac.webkit.org/changeset/222488>
WebKit Commit Bot
Comment 7 2017-09-25 20:30:01 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-09-27 12:18:34 PDT
<rdar://problem/34693004>
Note You need to log in before you can comment on or make changes to this bug.