Bug 178807

Summary: Web Inspector: Canvas Tab: no path components shown in recording content view after selecting a recording via View Recordings... dropdown
Product: WebKit Reporter: Blaze Burg <bburg>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, hi, inspector-bugzilla-changes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=178797
Bug Depends on:    
Bug Blocks: 173807, 175485    
Attachments:
Description Flags
Screenshot
none
Patch none

Blaze Burg
Reported 2017-10-25 10:18:50 PDT
Created attachment 324842 [details] Screenshot STR: 1. Visit acko.net 2. Create a recording 3. Go back via arrow in jump bar 4. Select recording via View Recordings... => No path components shown at all
Attachments
Screenshot (267.05 KB, image/png)
2017-10-25 10:18 PDT, Blaze Burg 		no flags
Details
Patch (7.67 KB, patch)
2017-10-27 00:53 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-10-25 10:19:12 PDT
<rdar://problem/35176463>
Blaze Burg
Comment 2 2017-10-25 10:20:41 PDT
This only seems to occur for the first recording. If there are >1 recordings, the other ones don't have this problem.
Devin Rousso
Comment 3 2017-10-27 00:53:59 PDT
Created attachment 325133 [details] Patch
Blaze Burg
Comment 4 2017-10-30 13:27:12 PDT
Comment on attachment 325133 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325133&action=review r=me > Source/WebInspectorUI/UserInterface/Views/CanvasTreeElement.js:-98 > - this.addRepresentedObjectToNewChildQueue(event.data.item); I'm not familiar with the function, what was the intent behind this.addRepresentedObjectToNewChildQueue?
Devin Rousso
Comment 5 2017-10-30 13:33:17 PDT
Comment on attachment 325133 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=325133&action=review >> Source/WebInspectorUI/UserInterface/Views/CanvasTreeElement.js:-98 >> - this.addRepresentedObjectToNewChildQueue(event.data.item); > > I'm not familiar with the function, what was the intent behind this.addRepresentedObjectToNewChildQueue? `addRepresentedObjectToNewChildQueue` is implemented on FolderizedTreeElement.js:113. The comment in the function says this: // This queue reduces flashing as resources load and change folders when their type becomes known. It keeps a queue of items to add and runs through it once per frame, basically batching the add/remove operations. For things that don't "load" per se, however, it is probably unnecessary. Canvases/ShaderPrograms don't ever change type, so we don't really need to worry about that.
WebKit Commit Bot
Comment 6 2017-10-30 13:53:06 PDT
Comment on attachment 325133 [details] Patch Clearing flags on attachment: 325133 Committed r224200: <https://trac.webkit.org/changeset/224200>
WebKit Commit Bot
Comment 7 2017-10-30 13:53:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.