Bug 179716

Summary: Remove GTK web inspector images
Product: WebKit Reporter: Michael Catanzaro <mcatanzaro>
Component: Web InspectorAssignee: Michael Catanzaro <mcatanzaro>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, cgarcia, fujii.hironori, inspector-bugzilla-changes, joepeck, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch
none
Screenshot
none
Patch none

Michael Catanzaro
Reported 2017-11-14 20:20:04 PST
Now that bug #166460 is resolved, we no longer need a separate set of web inspector images for non-Apple ports.
Attachments
Patch (725.23 KB, patch)
2017-11-14 20:35 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Screenshot (149.90 KB, image/png)
2017-11-14 20:39 PST, Michael Catanzaro 		no flags
Details
Patch (726.77 KB, patch)
2017-11-15 08:32 PST, Michael Catanzaro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2017-11-14 20:35:59 PST
Created attachment 326964 [details] Patch
Michael Catanzaro
Comment 2 2017-11-14 20:39:31 PST
Created attachment 326965 [details] Screenshot The Apple icons also better match the look and feel of the web inspector.
Michael Catanzaro
Comment 3 2017-11-15 08:32:25 PST
Created attachment 326984 [details] Patch
Michael Catanzaro
Comment 4 2017-11-15 08:56:59 PST
Committed r224877: <https://trac.webkit.org/changeset/224877>
Radar WebKit Bug Importer
Comment 5 2017-11-15 09:31:14 PST
<rdar://problem/35561853>
Joseph Pecoraro
Comment 6 2017-11-17 10:46:28 PST
Great! There are a few places in CSS we might be able to remove now. For example: > /* FIXME: <https://webkit.org/b/155282> [GTK] Web Inspector: Add new GTK+ icons for different Heap Allocations Timeline Views (Heap Snapshots) */ > body:not(.mac-platform, .windows-platform) .heap-snapshot-record .icon, > body:not(.mac-platform, .windows-platform) .heap-snapshot-summary-icon .icon, > body:not(.mac-platform, .windows-platform) .heap-snapshot-instances-icon .icon, > body:not(.mac-platform, .windows-platform) .snapshot-diff-icon .icon { > content: url(../Images/ResultLine.svg); > } I'll take a look today.
Note You need to log in before you can comment on or make changes to this bug.