Bug 182950

Summary: Web Inspector: Canvas tab: don't automatically select a recording when viewing a canvas
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 173807, 175485    
Attachments:
Description Flags
Patch
none
[Image] After Patch is applied
none
Patch none

Devin Rousso
Reported 2018-02-19 17:47:01 PST
I find it annoying that when I select a Canvas from the overview, it automatically selects the first recording, causing the recording preview to be shown instead of the current content. We should change this to be where we only select a recording when we are directly viewing a recording (e.g. when a recording finishes or if the user selects one from the menu in the overview).
Attachments
Patch (7.11 KB, patch)
2018-02-19 17:55 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] After Patch is applied (13.13 KB, image/png)
2018-02-19 17:55 PST, Devin Rousso 		no flags
Details
Patch (6.08 KB, patch)
2018-05-14 15:16 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2018-02-19 17:55:16 PST
Created attachment 334215 [details] Patch
Devin Rousso
Comment 2 2018-02-19 17:55:28 PST
Created attachment 334216 [details] [Image] After Patch is applied
Matt Baker
Comment 3 2018-05-10 12:56:36 PDT
Comment on attachment 334215 [details] Patch I'd like to see this behavior pushed into ScopeBar itself. ScopeBar's constructor takes a defaultItem, which AFAIK is never null (although we don't assert this). You could refactor ScopeBar to allow it to be null, and use ScopeBar.prototype.resetToDefault whenever you want to set the selection to none.
Devin Rousso
Comment 4 2018-05-14 13:18:08 PDT
(In reply to Matt Baker from comment #3) > Comment on attachment 334215 [details] > Patch > > I'd like to see this behavior pushed into ScopeBar itself. ScopeBar's > constructor takes a defaultItem, which AFAIK is never null (although we > don't assert this). You could refactor ScopeBar to allow it to be null, and > use ScopeBar.prototype.resetToDefault whenever you want to set the selection > to none. My worry about doing this is that it would break other uses of `WI.ScopeBar`, as I don't think any of them currently support a non-selectable default item (or even want that functionality). It might be worth doing as a followup, but I'm not sure how applicable it would be elsewhere.
Matt Baker
Comment 5 2018-05-14 13:30:26 PDT
Comment on attachment 334215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334215&action=review r=me > Source/WebInspectorUI/UserInterface/Views/CanvasTabContentView.js:42 > + this._canvasTreeOutline.allowsRepeatSelection = true; I think this change deserves an explanation in the change log.
Devin Rousso
Comment 6 2018-05-14 15:11:32 PDT
Comment on attachment 334215 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=334215&action=review >> Source/WebInspectorUI/UserInterface/Views/CanvasTabContentView.js:42 >> + this._canvasTreeOutline.allowsRepeatSelection = true; > > I think this change deserves an explanation in the change log. I'm not actually sure why this was there 😅. I tried removing it and found no difference.
Devin Rousso
Comment 7 2018-05-14 15:16:05 PDT
Created attachment 340366 [details] Patch
WebKit Commit Bot
Comment 8 2018-05-14 16:01:30 PDT
Comment on attachment 340366 [details] Patch Clearing flags on attachment: 340366 Committed r231773: <https://trac.webkit.org/changeset/231773>
WebKit Commit Bot
Comment 9 2018-05-14 16:01:32 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2018-05-14 16:03:40 PDT
<rdar://problem/40237015>
Note You need to log in before you can comment on or make changes to this bug.