Bug 191382

Summary:

[SVG2]: Add bounding-box keyword to pointer-events

Product:

WebKit

Reporter:

Dirk Schulze <krit>

Component:

SVG

Assignee:

Dirk Schulze <krit>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, dbates, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, joepeck, kondapallykalyan, macpherson, menard, pdr, rniwa, sabouhallawa, schenney, sergio, simon.fraser, webkit-bug-importer, zimmermann

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

191292

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-sierra	none
Archive of layout-test-results from ews104 for mac-sierra-wk2	none
Archive of layout-test-results from ews205 for win-future	none
Archive of layout-test-results from ews202 for win-future	none
Archive of layout-test-results from ews115 for mac-sierra	none
Patch	none
Archive of layout-test-results from ews212 for win-future	none
Patch	none

Dirk Schulze

Reported 2018-11-07 10:15:35 PST

Add support for bounding-box keyword for the the pointer-events CSS property. https://www.w3.org/TR/SVG2/interact.html#PointerEventsProperty

Attachments
Patch (57.74 KB, patch) 2018-11-07 10:24 PST, Dirk Schulze	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-sierra (2.70 MB, application/zip) 2018-11-07 11:26 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews104 for mac-sierra-wk2 (3.66 MB, application/zip) 2018-11-07 11:52 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews205 for win-future (13.42 MB, application/zip) 2018-11-07 13:25 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews202 for win-future (13.48 MB, application/zip) 2018-11-07 15:18 PST, EWS Watchlist	no flags	Details
Archive of layout-test-results from ews115 for mac-sierra (3.41 MB, application/zip) 2018-11-07 16:37 PST, EWS Watchlist	no flags	Details
Patch (69.54 KB, patch) 2019-10-22 06:31 PDT, Dirk Schulze	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews212 for win-future (14.36 MB, application/zip) 2019-10-22 08:31 PDT, EWS Watchlist	no flags	Details
Patch (124.97 KB, patch) 2019-10-22 10:25 PDT, Dirk Schulze	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Dirk Schulze

Comment 1 2018-11-07 10:24:40 PST

Created attachment 354108 [details] Patch

EWS Watchlist

Comment 2 2018-11-07 11:26:19 PST

Comment on attachment 354108 [details] Patch Attachment 354108 [details] did not pass mac-ews (mac): Output: https://webkit-queues.webkit.org/results/9895596 New failing tests: svg/custom/pointer-events-text-css-transform.svg

EWS Watchlist

Comment 3 2018-11-07 11:26:20 PST

Created attachment 354113 [details] Archive of layout-test-results from ews101 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-sierra Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 4 2018-11-07 11:52:42 PST

Comment on attachment 354108 [details] Patch Attachment 354108 [details] did not pass mac-wk2-ews (mac-wk2): Output: https://webkit-queues.webkit.org/results/9895718 New failing tests: svg/custom/pointer-events-text-css-transform.svg

EWS Watchlist

Comment 5 2018-11-07 11:52:43 PST

Created attachment 354121 [details] Archive of layout-test-results from ews104 for mac-sierra-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-sierra-wk2 Platform: Mac OS X 10.12.6

EWS Watchlist

Comment 6 2018-11-07 13:25:01 PST

Comment on attachment 354108 [details] Patch Attachment 354108 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9896938 New failing tests: svg/custom/pointer-events-image-css-transform.svg svg/custom/pointer-events-image.svg svg/custom/pointer-events-text.svg svg/custom/pointer-events-path.svg svg/custom/pointer-events-text-css-transform.svg

EWS Watchlist

Comment 7 2018-11-07 13:25:13 PST

Created attachment 354137 [details] Archive of layout-test-results from ews205 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews205 Port: win-future Platform: CYGWIN_NT-6.1-2.9.0-0.318-5-3-x86_64-64bit

EWS Watchlist

Comment 8 2018-11-07 15:18:32 PST

Comment on attachment 354108 [details] Patch Attachment 354108 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/9898887 New failing tests: svg/custom/pointer-events-text.svg svg/custom/pointer-events-text-css-transform.svg webanimations/leak-document-with-web-animation.html svg/custom/pointer-events-path.svg svg/custom/pointer-events-image-css-transform.svg svg/custom/pointer-events-image.svg

EWS Watchlist

Comment 9 2018-11-07 15:18:44 PST

Created attachment 354164 [details] Archive of layout-test-results from ews202 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews202 Port: win-future Platform: CYGWIN_NT-6.1-2.10.0-0.325-5-3-x86_64-64bit

EWS Watchlist

Comment 10 2018-11-07 16:37:37 PST

Comment on attachment 354108 [details] Patch Attachment 354108 [details] did not pass mac-debug-ews (mac): Output: https://webkit-queues.webkit.org/results/9900151 New failing tests: svg/custom/pointer-events-text-css-transform.svg

EWS Watchlist

Comment 11 2018-11-07 16:37:39 PST

Created attachment 354180 [details] Archive of layout-test-results from ews115 for mac-sierra The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-sierra Platform: Mac OS X 10.12.6

Dean Jackson

Comment 12 2018-11-12 10:18:21 PST

Comment on attachment 354108 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=354108&action=review > Source/WebCore/css/CSSValueKeywords.in:994 > +bounding-box I wonder why CSSValueKeywords.in isn't generated from CSSProperties.json? > LayoutTests/platform/mac/svg/custom/pointer-events-path-expected.txt:664 > + chunk 1 text run 1 at (390.00,640.00) startOffset 0 endOffset 4 width 29.34: "miss" > + RenderSVGRect {rect} at (0,0) size 0x0 [fill={[type=SOLID] [color=#FFA500]}] [x=442.00] [y=600.00] [width=50.00] [height=50.00] > + RenderSVGText {text} at (447,606) size 30x18 contains 1 chunk(s) Yikes. Why are all these non-text dumps?

Simon Fraser (smfr)

Comment 13 2019-05-21 11:49:58 PDT

We should clean this up and land it.

Radar WebKit Bug Importer

Comment 14 2019-05-21 11:50:07 PDT

<rdar://problem/50994138>

Radar WebKit Bug Importer

Comment 15 2019-05-21 11:50:08 PDT

<rdar://problem/50994132>

Dirk Schulze

Comment 16 2019-10-22 06:31:12 PDT

Created attachment 381540 [details] Patch

EWS Watchlist

Comment 17 2019-10-22 08:31:57 PDT

Comment on attachment 381540 [details] Patch Attachment 381540 [details] did not pass win-ews (win): Output: https://webkit-queues.webkit.org/results/13163015 New failing tests: svg/custom/pointer-events-image-css-transform.svg svg/custom/pointer-events-image.svg svg/custom/pointer-events-text-css-transform.svg svg/custom/pointer-events-path.svg svg/custom/pointer-events-text.svg

EWS Watchlist

Comment 18 2019-10-22 08:31:59 PDT

Created attachment 381546 [details] Archive of layout-test-results from ews212 for win-future The attached test failures were seen while running run-webkit-tests on the win-ews. Bot: ews212 Port: win-future Platform: CYGWIN_NT-10.0-17763-3.0.5-338.x86_64-x86_64-64bit

Dirk Schulze

Comment 19 2019-10-22 10:25:22 PDT

Created attachment 381559 [details] Patch

WebKit Commit Bot

Comment 20 2019-10-22 12:57:39 PDT

Comment on attachment 381559 [details] Patch Clearing flags on attachment: 381559 Committed r251444: <https://trac.webkit.org/changeset/251444>

WebKit Commit Bot

Comment 21 2019-10-22 12:57:41 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.