Bug 191596

Summary: [iOS] Shift + Tab does not focus previous field
Product: WebKit Reporter: Daniel Bates <dbates>
Component: WebKit Misc.Assignee: Daniel Bates <dbates>
Status: RESOLVED FIXED    
Severity: Normal CC: megan_gardner, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar, PlatformOnly
Version: WebKit Local Build   
Hardware: iPhone / iPad   
OS: iOS 12   
URL: http://www.facebook.com
Bug Depends on: 173341    
Bug Blocks: 190571    
Attachments:
Description Flags
Patch and layout tests
none
For EWS
none
To Land none

Daniel Bates
Reported 2018-11-13 13:17:14 PST
Pressing Shift + Tab does not focus the previous field on facebook.com. Steps to reproduce: The following assume that a hardware keyboard is attached. 1. Visit <https://www.facebook.com>. 2. Tap the password field. 3. Press Shift + Tab. Then the Email or Phone field should be focused. But there is no change in focus.
Attachments
Patch and layout tests (27.01 KB, patch)
2018-11-13 13:50 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
For EWS (27.28 KB, patch)
2018-11-13 16:42 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
To Land (28.26 KB, patch)
2018-11-15 11:04 PST, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2018-11-13 13:17:27 PST
<rdar://problem/45892053>
Daniel Bates
Comment 2 2018-11-13 13:50:24 PST
Created attachment 354699 [details] Patch and layout tests
Wenson Hsieh
Comment 3 2018-11-13 15:03:52 PST
Comment on attachment 354699 [details] Patch and layout tests View in context: https://bugs.webkit.org/attachment.cgi?id=354699&action=review r=me, with non-internal iOS builds fixed > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2427 > + return [self isFirstResponder]; Have you considered consulting `AssistedNodeInformation.hasNextNode` or `AssistedNodeInformation.hasPreviousNode` as well?
Wenson Hsieh
Comment 4 2018-11-13 15:07:54 PST
Comment on attachment 354699 [details] Patch and layout tests View in context: https://bugs.webkit.org/attachment.cgi?id=354699&action=review > Tools/ChangeLog:21 > + and an array of modifier keys. The behavior of this function is analagous to eventSender.keyDown(). Nit - analagous => analogous > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:405 > + // Character can be either a single Unicode code point or a the name of a special key (e.g. "downArrow"). Nit - "or a the"
Daniel Bates
Comment 5 2018-11-13 16:42:04 PST
Created attachment 354728 [details] For EWS
Daniel Bates
Comment 6 2018-11-13 16:42:53 PST
Comment on attachment 354728 [details] For EWS For EWS. Need to address review feedback.
Daniel Bates
Comment 7 2018-11-15 10:58:18 PST
(In reply to Wenson Hsieh from comment #3) > Comment on attachment 354699 [details] > Patch and layout tests > > View in context: > https://bugs.webkit.org/attachment.cgi?id=354699&action=review > > r=me, with non-internal iOS builds fixed > > > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2427 > > + return [self isFirstResponder]; > > Have you considered consulting `AssistedNodeInformation.hasNextNode` or > `AssistedNodeInformation.hasPreviousNode` as well? Will write in terms of AssistedNodeInformation.has{Next, Previous}Node such that the beginning of -canPerformActionForWebView reads: [[ - (BOOL)canPerformActionForWebView:(SEL)action withSender:(id)sender { { if (action == @selector(_nextAccessoryTab:)) return hasAssistedNode(_assistedNodeInformation) && _assistedNodeInformation.hasNextNode; if (action == @selector(_previousAccessoryTab:)) return hasAssistedNode(_assistedNodeInformation) && _assistedNodeInformation.hasPreviousNode; ... ]]
Daniel Bates
Comment 8 2018-11-15 10:58:33 PST
(In reply to Wenson Hsieh from comment #4) > Comment on attachment 354699 [details] > Patch and layout tests > > View in context: > https://bugs.webkit.org/attachment.cgi?id=354699&action=review > > > Tools/ChangeLog:21 > > + and an array of modifier keys. The behavior of this function is analagous to eventSender.keyDown(). > > Nit - analagous => analogous > Will fix. > > Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm:405 > > + // Character can be either a single Unicode code point or a the name of a special key (e.g. "downArrow"). > > Nit - "or a the" Will fix.
Daniel Bates
Comment 9 2018-11-15 11:04:55 PST
Created attachment 354957 [details] To Land
Daniel Bates
Comment 10 2018-11-15 11:15:39 PST
Committed r238235: <https://trac.webkit.org/changeset/238235>
Note You need to log in before you can comment on or make changes to this bug.