Bug 192105

Summary:

Web Inspector: Audit: "Add Default Audits" shown when there are no filter results

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

Web Inspector

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, ews-watchlist, hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Bug Depends on:

190754

Bug Blocks:

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Patch	none

Devin Rousso

Reported 2018-11-28 14:40:57 PST

This is due to the fact that empty content placeholders are cached per `WI.TreeOutline`, meaning that when the "Add Default Audits" is shown for the first time, it is used instead of the "No Filter Results". We should remove this caching.

Attachments
Patch (8.08 KB, patch) 2018-11-28 14:55 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (2.63 MB, application/zip) 2018-11-28 17:33 PST, EWS Watchlist	no flags	Details
Patch (16.10 KB, patch) 2018-12-03 15:35 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2018-11-28 14:55:19 PST

Created attachment 355922 [details] Patch

EWS Watchlist

Comment 2 2018-11-28 17:33:08 PST Comment hidden (obsolete)

Comment on attachment 355922 [details] Patch Attachment 355922 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: https://webkit-queues.webkit.org/results/10189022 New failing tests: imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https.html

EWS Watchlist

Comment 3 2018-11-28 17:33:10 PST Comment hidden (obsolete)

Created attachment 355950 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.13.6

Radar WebKit Bug Importer

Comment 4 2018-12-03 10:41:22 PST

<rdar://problem/46423572>

Matt Baker

Comment 5 2018-12-03 14:17:21 PST

Comment on attachment 355922 [details] Patch r-, due to some issues that came up during testing: Before applying patch: - I can't reproduce the bug: when I filter the sidebar "No Filter Results" is always shown. - It looks like "Add Default Audits" isn't shown after removing all audits from the sidebar. After applying patch: - "Add Default Audits" works now. - After removing all audits, adding filter text causes "No Filter Results" to be shown again. Clearing the filter text does not remove the message, and there is no way to add the default audits.

Devin Rousso

Comment 6 2018-12-03 15:35:44 PST

Created attachment 356421 [details] Patch

Matt Baker

Comment 7 2018-12-03 16:23:26 PST

Comment on attachment 356421 [details] Patch r=me

WebKit Commit Bot

Comment 8 2018-12-03 16:57:43 PST

Comment on attachment 356421 [details] Patch Clearing flags on attachment: 356421 Committed r238831: <https://trac.webkit.org/changeset/238831>

WebKit Commit Bot

Comment 9 2018-12-03 16:57:44 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.