Bug 196719

Summary: [Web GPU] GPURenderPassEncoder updates: setBlendColor, setViewport, setScissorRect
Product: WebKit Reporter: Justin Fan <justin_fan>
Component: WebGPUAssignee: Justin Fan <justin_fan>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, dino, esprehn+autocc, ews-watchlist, graouts, kondapallykalyan, mmaxfield, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Justin Fan
Reported 2019-04-08 18:21:14 PDT
[Web GPU] GPURenderPassEncoder updates: setBlendColor, setViewport, setScissorRect
Attachments
Patch (16.50 KB, patch)
2019-04-08 18:49 PDT, Justin Fan 		no flags
DetailsFormatted DiffDiff
Patch for landing (18.72 KB, patch)
2019-04-09 12:07 PDT, Justin Fan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Justin Fan
Comment 1 2019-04-08 18:49:27 PDT
Created attachment 367009 [details] Patch
Myles C. Maxfield
Comment 2 2019-04-08 20:27:17 PDT
Comment on attachment 367009 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=367009&action=review > LayoutTests/webgpu/blend-triangle-strip.html:-57 > - dstFactor: "one", Why modify this test? Why didn’t this modification cause a required change in the expected results? Instead of modifying this test, we should make a new test.
Justin Fan
Comment 3 2019-04-09 12:07:43 PDT
Created attachment 367059 [details] Patch for landing
WebKit Commit Bot
Comment 4 2019-04-09 13:02:33 PDT
The commit-queue encountered the following flaky tests while processing attachment 367059 [details]: imported/w3c/web-platform-tests/xhr/event-upload-progress.htm bug 196736 (author: youennf@gmail.com) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2019-04-09 13:03:24 PDT
Comment on attachment 367059 [details] Patch for landing Clearing flags on attachment: 367059 Committed r244093: <https://trac.webkit.org/changeset/244093>
WebKit Commit Bot
Comment 6 2019-04-09 13:03:25 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2019-04-09 13:04:39 PDT
<rdar://problem/49746664>
Note You need to log in before you can comment on or make changes to this bug.