Bug 197470

Summary: Web Inspector: Audit: make it easier to jump to any returned DOM node in the Elements tab
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, joepeck, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=197591
Bug Depends on: 190754    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
[Image] After Patch is applied (Inline)
none
[Image] After Patch is applied (Expanded)
none
Patch none

Devin Rousso
Reported 2019-05-01 12:23:16 PDT
When returning DOM nodes via `domNodes`, there's no "obvious" way (there's a context menu option) to jump to the live location of that DOM node in the DOM tree (e.g. in the Elements tab).
Attachments
Patch (12.65 KB, patch)
2019-05-03 22:13 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (11.08 KB, patch)
2019-05-03 22:17 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
[Image] After Patch is applied (Inline) (765.35 KB, image/png)
2019-05-17 21:18 PDT, Devin Rousso 		no flags
Details
[Image] After Patch is applied (Expanded) (913.03 KB, image/png)
2019-05-17 21:18 PDT, Devin Rousso 		no flags
Details
Patch (11.40 KB, patch)
2019-05-17 21:22 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-05-03 22:13:49 PDT
Created attachment 369050 [details] Patch
Radar WebKit Bug Importer
Comment 2 2019-05-03 22:14:00 PDT
<rdar://problem/50466773>
Radar WebKit Bug Importer
Comment 3 2019-05-03 22:14:00 PDT
<rdar://problem/50466774>
Devin Rousso
Comment 4 2019-05-03 22:17:45 PDT
Created attachment 369052 [details] Patch Split `WI.TreeElement` fix into a separate bug 197591.
Joseph Pecoraro
Comment 5 2019-05-17 16:12:25 PDT
Comment on attachment 369052 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=369052&action=review r=me > Source/WebInspectorUI/ChangeLog:18 > + Provide a way to insert a go-to arrow right after the: Should include a screenshot of what this looks like to make review easier.
Devin Rousso
Comment 6 2019-05-17 21:18:19 PDT
Created attachment 370180 [details] [Image] After Patch is applied (Inline)
Devin Rousso
Comment 7 2019-05-17 21:18:40 PDT
Created attachment 370181 [details] [Image] After Patch is applied (Expanded)
Devin Rousso
Comment 8 2019-05-17 21:22:00 PDT
Created attachment 370182 [details] Patch
WebKit Commit Bot
Comment 9 2019-05-17 22:10:35 PDT
Comment on attachment 370182 [details] Patch Clearing flags on attachment: 370182 Committed r245497: <https://trac.webkit.org/changeset/245497>
WebKit Commit Bot
Comment 10 2019-05-17 22:10:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.