Bug 198719

Summary: Web Inspector: Audit: missing demo audits for WebInspectorAudit functions
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hi, inspector-bugzilla-changes, mattbaker, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on: 190754    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
mattbaker: review+
[Image] After Patch is applied
none
Patch none

Devin Rousso
Reported 2019-06-10 08:22:49 PDT
There's no example usage of `WebInspectorudit.DOM` (as an example) other than the tests.
Attachments
Patch (36.70 KB, patch)
2019-06-10 08:53 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Patch (35.23 KB, patch)
2019-06-10 08:57 PDT, Devin Rousso 		mattbaker: review+
DetailsFormatted DiffDiff
[Image] After Patch is applied (1.37 MB, image/png)
2019-06-10 10:19 PDT, Devin Rousso 		no flags
Details
Patch (35.14 KB, patch)
2019-07-01 23:26 PDT, Devin Rousso 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2019-06-10 08:53:35 PDT
Created attachment 371746 [details] Patch
Devin Rousso
Comment 2 2019-06-10 08:57:48 PDT
Created attachment 371748 [details] Patch
Devin Rousso
Comment 3 2019-06-10 10:19:36 PDT
Created attachment 371756 [details] [Image] After Patch is applied I messed around with `console.screenshot` to get the full image :P
Matt Baker
Comment 4 2019-07-01 18:14:00 PDT
Comment on attachment 371748 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371748&action=review r=me > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:1082 > +localizedStrings["These tests are examples of how to use %s to access information not normally available via JavaScript."] = "These tests are examples of how to use %s to access information not normally available via JavaScript."; "via JavaScript" -> "to JavaScript" > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:1083 > +localizedStrings["These tests are examples of how to use %s to get more information about DOM nodes."] = "These tests are examples of how to use %s to get more information about DOM nodes."; Why is the "more" necessary? What does it convey? Can it just be "get information about"? > Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js:1085 > +localizedStrings["These tests are examples of how to use %s to get more information about the accessibility tree."] = "These tests are examples of how to use %s to get more information about the accessibility tree."; For all of these, I'd change "These tests are examples of how to" to "These tests demonstrate how to".
Devin Rousso
Comment 5 2019-07-01 23:26:50 PDT
Created attachment 373304 [details] Patch
WebKit Commit Bot
Comment 6 2019-07-02 00:09:50 PDT
Comment on attachment 373304 [details] Patch Clearing flags on attachment: 373304 Committed r247042: <https://trac.webkit.org/changeset/247042>
WebKit Commit Bot
Comment 7 2019-07-02 00:09:51 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2019-07-02 00:10:16 PDT
<rdar://problem/52507207>
Note You need to log in before you can comment on or make changes to this bug.