Bug 206230

Summary:

[Texmap] Remove unused private variable

Product:

WebKit

Reporter:

Víctor M. Jáquez L. <vjaquez>

Component:

WebKit Misc.

Assignee:

Víctor M. Jáquez L. <vjaquez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

calvaris, cmarcelo, commit-queue, ddkilzer, ews-feeder, ews-watchlist, kondapallykalyan, luiz, noam, pnormand, webkit-bug-importer, zan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	ddkilzer: review+, ews-feeder: commit-queue-
Archive of layout-test-results from webkit-cq-01 for mac-mojave	none

Víctor M. Jáquez L.

Reported 2020-01-14 07:25:37 PST

m_textureID is not used

Attachments
Patch (1.37 KB, patch) 2020-01-14 07:31 PST, Víctor M. Jáquez L.	ddkilzer: review+ ews-feeder: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-cq-01 for mac-mojave (3.35 MB, application/zip) 2020-01-15 14:50 PST, WebKit Commit Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Víctor M. Jáquez L.

Comment 1 2020-01-14 07:31:12 PST

Created attachment 387653 [details] Patch

David Kilzer (:ddkilzer)

Comment 2 2020-01-15 10:54:36 PST

Comment on attachment 387653 [details] Patch r=me

WebKit Commit Bot

Comment 3 2020-01-15 12:48:46 PST

The commit-queue encountered the following flaky tests while processing attachment 387653 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) media/track/track-in-band-metadata-display-order.html bug 206226 (author: jer.noble@apple.com) The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 4 2020-01-15 12:48:47 PST

The commit-queue encountered the following flaky tests while processing attachment 387653 [details]: The commit-queue is continuing to process your patch.

WebKit Commit Bot

Comment 5 2020-01-15 14:50:23 PST

Comment on attachment 387653 [details] Patch Rejecting attachment 387653 [details] from commit-queue. New failing tests: editing/spelling/spellcheck-attribute.html Full output: https://webkit-queues.webkit.org/results/13305032

WebKit Commit Bot

Comment 6 2020-01-15 14:50:25 PST

Created attachment 387851 [details] Archive of layout-test-results from webkit-cq-01 for mac-mojave The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: webkit-cq-01 Port: mac-mojave Platform: Mac OS X 10.14.6

Víctor M. Jáquez L.

Comment 7 2020-01-16 07:13:28 PST

I don't think those flaky tests turned flaky because of this patch.

EWS

Comment 8 2020-01-16 08:23:56 PST

Comment on attachment 387653 [details] Patch Rejecting attachment 387653 [details] from commit-queue. vjaquez@igalia.com does not have committer permissions according to https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.

Philippe Normand

Comment 9 2020-01-16 08:27:22 PST

Committed r254685: <https://trac.webkit.org/changeset/254685>

Radar WebKit Bug Importer

Comment 10 2020-01-16 08:28:20 PST

<rdar://problem/58644913>

Note You need to log in before you can comment on or make changes to this bug.