Bug 206334

Summary: [LFC] Fix CMake Build
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Layout and RenderingAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, bfulgham, commit-queue, ews-watchlist, gyuyoung.kim, ryuan.choi, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Don Olmstead
Reported 2020-01-15 18:47:15 PST
Fix the CMake bits so non-Apple ports can compile.
Attachments
Patch (13.65 KB, patch)
2020-01-15 18:51 PST, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2020-01-15 18:51:41 PST
Created attachment 387886 [details] Patch
alan
Comment 2 2020-01-15 18:55:34 PST
Comment on attachment 387886 [details] Patch Thanks for fixing it!
Don Olmstead
Comment 3 2020-01-15 18:57:09 PST
(In reply to zalan from comment #2) > Comment on attachment 387886 [details] > Patch > > Thanks for fixing it! No problem! Will land after EWS comes back.
WebKit Commit Bot
Comment 4 2020-01-15 19:49:55 PST
The commit-queue encountered the following flaky tests while processing attachment 387886 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2020-01-15 19:50:35 PST
Comment on attachment 387886 [details] Patch Clearing flags on attachment: 387886 Committed r254666: <https://trac.webkit.org/changeset/254666>
WebKit Commit Bot
Comment 6 2020-01-15 19:50:37 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 7 2020-01-15 19:51:11 PST
<rdar://problem/58631832>
Note You need to log in before you can comment on or make changes to this bug.