Bug 206494

Summary: ScrollableArea.cpp(63): error C2338: ScrollableArea_should_stay_small
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: PlatformAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: ap, cathiechen, ddkilzer, don.olmstead, rniwa, ross.kirsling, ryanhaddad, simon.fraser, tsavell
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Fujii Hironori
Reported 2020-01-20 04:01:16 PST
ScrollableArea.cpp(63): error C2338: ScrollableArea_should_stay_small AppleWin 32bit can't compile since r254807 (Bug 204882) > C:\webkit\gc\Source\WebCore\platform/ScrollableArea.cpp(63): error C2338: ScrollableArea_should_stay_small
Attachments
Patch (2.57 KB, patch)
2020-01-20 04:10 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2020-01-20 04:10:50 PST
Created attachment 388228 [details] Patch
cathiechen
Comment 2 2020-01-20 05:06:49 PST
LGTM, thanks for fixing this!
cathiechen
Comment 3 2020-01-20 07:44:31 PST
Comment on attachment 388228 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=388228&action=review > Source/WebCore/platform/ScrollableArea.h:412 > + ScrollBehaviorStatus m_currentScrollBehaviorStatus { ScrollBehaviorStatus::NotInAnimation }; Hmmm, it seems we don't have to expand the size, we can use the bit field in stead, like m_currentScrollType. Currently, ScrollBehaviorStatus only have two values, so 1 bit seems enough.
David Kilzer (:ddkilzer)
Comment 4 2020-01-20 13:48:46 PST
This static assertion failure broke some internal Apple builds as well.
Fujii Hironori
Comment 5 2020-01-20 17:42:14 PST
Cathiechen, it sounds a good idea. I think it should be reverted to fix internal Apple builds as soon as possible. Reverted in r254839. *** This bug has been marked as a duplicate of bug 204882 ***
cathiechen
Comment 6 2020-01-20 22:20:37 PST
Thanks, I'll fix this in the new patch.
Note You need to log in before you can comment on or make changes to this bug.