Bug 206634

Summary: WTF: Remove old iOS version macros
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: Tools / TestsAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, cdumez, cmarcelo, commit-queue, darin, dbates, ews-watchlist, krollin, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=206096
Attachments:
Description Flags
Patch
none
Patch none

Jonathan Bedard
Reported 2020-01-22 17:29:19 PST
We have a handful of old iOS 11 and 12 macros in WTF which should be removed.
Attachments
Patch (8.59 KB, patch)
2020-01-22 17:34 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch (8.60 KB, patch)
2020-01-23 13:20 PST, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-01-22 17:31:02 PST
<rdar://problem/58818561>
Jonathan Bedard
Comment 2 2020-01-22 17:34:23 PST
Created attachment 388494 [details] Patch
Darin Adler
Comment 3 2020-01-22 20:22:23 PST
Comment on attachment 388494 [details] Patch All looks right to me
Jonathan Bedard
Comment 4 2020-01-23 13:20:02 PST
Created attachment 388586 [details] Patch
Jonathan Bedard
Comment 5 2020-01-23 13:21:22 PST
Discovered I had changed 101400 to 101500 for HAVE_CORETEXT_AUTO_OPTICAL_SIZING in a final audit, sending it through EWS one final time before landing.
WebKit Commit Bot
Comment 6 2020-01-24 08:31:56 PST
The commit-queue encountered the following flaky tests while processing attachment 388586 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 7 2020-01-24 08:32:31 PST
Comment on attachment 388586 [details] Patch Clearing flags on attachment: 388586 Committed r255073: <https://trac.webkit.org/changeset/255073>
WebKit Commit Bot
Comment 8 2020-01-24 08:32:33 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.