Bug 206920

Summary: Web Inspector: Some cookie table column headers should not be localizable
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, inspector-bugzilla-changes, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Nikita Vasilyev
Reported 2020-01-28 23:00:19 PST
Some of the localized headers should always be in English because they match cookie directives. Only "Name", "Value", and "Size" should be localized. https://github.com/WebKit/webkit/blob/2764480713d1f2b46b8f239eae5a99a6fcc3b6d9/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js#L169-L225 <rdar://57857579>
Attachments
Patch (2.76 KB, patch)
2020-01-28 23:04 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2020-01-28 23:04:25 PST
Created attachment 389107 [details] Patch
WebKit Commit Bot
Comment 2 2020-02-05 18:46:33 PST
The commit-queue encountered the following flaky tests while processing attachment 389107 [details]: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 3 2020-02-05 18:46:55 PST
The commit-queue encountered the following flaky tests while processing attachment 389107 [details]: editing/spelling/spellcheck-attribute.html bug 206178 (authors: g.czajkowski@samsung.com, mark.lam@apple.com, and rniwa@webkit.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 4 2020-02-05 19:36:08 PST
Comment on attachment 389107 [details] Patch Clearing flags on attachment: 389107 Committed r255896: <https://trac.webkit.org/changeset/255896>
WebKit Commit Bot
Comment 5 2020-02-05 19:36:10 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.