Bug 207322

Summary: Web Inspector: REGRESSION(?): Search: selecting a DOM node search result switches to the Elements Tab
Product: WebKit Reporter: Devin Rousso <hi>
Component: Web InspectorAssignee: Devin Rousso <hi>
Status: RESOLVED MOVED    
Severity: Normal CC: bburg, commit-queue, hi, inspector-bugzilla-changes, jonlee, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=207422
Attachments:
Description Flags
Patch none

Devin Rousso
Reported 2020-02-05 20:30:20 PST
# STEPS TO REPRODUCE: 1. inspect any page 2. search for "div" via the Search Tab => as soon as results start appearing in the Search Tab, Web Inspector will instantly switch to the Elements Tab and select the node that matches the search result
Attachments
Patch (2.28 KB, patch)
2020-02-05 20:33 PST, Devin Rousso 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Devin Rousso
Comment 1 2020-02-05 20:33:39 PST
Created attachment 389934 [details] Patch
Blaze Burg
Comment 2 2020-02-06 13:35:16 PST
Comment on attachment 389934 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389934&action=review r=me > Source/WebInspectorUI/ChangeLog:14 > + such, we should update it's position in the `_recentTabContentViews` list so that we can use So, the bug is that the Search Tab results content view wasn't the most recent in the list (the most recent being preferred over, say, Elements tab) ?
Devin Rousso
Comment 3 2020-02-06 13:43:28 PST
Comment on attachment 389934 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=389934&action=review >> Source/WebInspectorUI/ChangeLog:14 >> + such, we should update it's position in the `_recentTabContentViews` list so that we can use > > So, the bug is that the Search Tab results content view wasn't the most recent in the list (the most recent being preferred over, say, Elements tab) ? Yup!
WebKit Commit Bot
Comment 4 2020-02-06 14:15:40 PST
Comment on attachment 389934 [details] Patch Clearing flags on attachment: 389934 Committed r255980: <https://trac.webkit.org/changeset/255980>
WebKit Commit Bot
Comment 5 2020-02-06 14:15:41 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2020-02-06 14:16:15 PST
<rdar://problem/59236869>
Jon Lee
Comment 7 2020-02-07 20:23:31 PST
Reopening. This was reverted by https://trac.webkit.org/changeset/256086/webkit in b207422.
Devin Rousso
Comment 8 2020-03-02 16:54:58 PST
This will be resolved by <https://webkit.org/b/207317>.
Note You need to log in before you can comment on or make changes to this bug.