Bug 208041

Summary: [GStreamer] TextCombinerGStreamer is failing to compile with Gst1.14
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: New BugsAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: aboya, bugs-noreply, calvaris, cgarcia, clopez, commit-queue, ews-watchlist, gustavo, menard, pnormand, vjaquez, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=208001
Attachments:
Description Flags
Patch
none
Patch none

Lauro Moura
Reported 2020-02-20 20:03:01 PST
[GStreamer] TextCombinerGStreamer is failing to compile with Gst1.14
Attachments
Patch (2.14 KB, patch)
2020-02-20 20:04 PST, Lauro Moura 		no flags
DetailsFormatted DiffDiff
Patch (1.83 KB, patch)
2020-02-21 03:44 PST, Lauro Moura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Lauro Moura
Comment 1 2020-02-20 20:04:45 PST
Created attachment 391376 [details] Patch
Xabier Rodríguez Calvar
Comment 2 2020-02-21 01:26:00 PST
Comment on attachment 391376 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391376&action=review > Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:110 > + gst_tag_list_unref(combinerPad->tags); unref and then assign to nullptr, which is what clear is doing > Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:113 > + gst_object_unref(combinerPad->funnelPad); ditto
Alicia Boya García
Comment 3 2020-02-21 02:39:01 PST
Comment on attachment 391376 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=391376&action=review >> Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:110 >> + gst_tag_list_unref(combinerPad->tags); > > unref and then assign to nullptr, which is what clear is doing g_clear_pointer(&combinerPad->tags, gst_tag_list_unref); >> Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:113 >> + gst_object_unref(combinerPad->funnelPad); > > ditto g_clear_pointer(&combinerPad->funnelPad, gst_object_unref);
Xabier Rodríguez Calvar
Comment 4 2020-02-21 03:00:06 PST
(In reply to Alicia Boya García from comment #3) > Comment on attachment 391376 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=391376&action=review > > >> Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:110 > >> + gst_tag_list_unref(combinerPad->tags); > > > > unref and then assign to nullptr, which is what clear is doing > > g_clear_pointer(&combinerPad->tags, gst_tag_list_unref); > > >> Source/WebCore/platform/graphics/gstreamer/TextCombinerGStreamer.cpp:113 > >> + gst_object_unref(combinerPad->funnelPad); > > > > ditto > > g_clear_pointer(&combinerPad->funnelPad, gst_object_unref); 👏🏼 I didn't remember this
Lauro Moura
Comment 5 2020-02-21 03:44:53 PST
Created attachment 391391 [details] Patch
Carlos Alberto Lopez Perez
Comment 6 2020-02-21 04:31:42 PST
(In reply to Lauro Moura from comment #0) > [GStreamer] TextCombinerGStreamer is failing to compile with Gst1.14 In general I appreciate giving more pointers to when this started to happen in the bug description or at least adding the related bug in the see also field :)
WebKit Commit Bot
Comment 7 2020-02-21 04:38:23 PST
Comment on attachment 391391 [details] Patch Clearing flags on attachment: 391391 Committed r257133: <https://trac.webkit.org/changeset/257133>
WebKit Commit Bot
Comment 8 2020-02-21 04:38:25 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 9 2020-02-21 04:39:16 PST
<rdar://problem/59665227>
Note You need to log in before you can comment on or make changes to this bug.