Bug 229853

Summary: [JSC] Fix WebKitAdditions directory traversal in offlineasm part 2
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Yusuke Suzuki
Reported 2021-09-03 01:10:27 PDT
[JSC] Fix WebKitAdditions directory traversal in offlineasm part 2
Attachments
Patch (12.21 KB, patch)
2021-09-03 01:17 PDT, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2021-09-03 01:17:43 PDT
Created attachment 437251 [details] Patch
Mark Lam
Comment 2 2021-09-03 04:04:47 PDT
Comment on attachment 437251 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=437251&action=review r=me > Source/JavaScriptCore/offlineasm/asm.rb:343 > + opts.on("--webkit-additions-path=PATH", "Flag to use deployment location.") do |path| Can you change “Flag to use deployment location” to “WebKitAdditions path”? > Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb:52 > + opts.on("--webkit-additions-path=PATH", "Flag to use deployment location.") do |path| Ditto. > Source/JavaScriptCore/offlineasm/generate_settings_extractor.rb:49 > + opts.on("--webkit-additions-path=PATH", "Flag to use deployment location.") do |path| Ditto.
Ryan Haddad
Comment 3 2021-09-03 10:47:25 PDT
rdar://82728326
Yusuke Suzuki
Comment 4 2021-09-03 11:15:46 PDT
Committed r282009 (241316@main): <https://commits.webkit.org/241316@main>
Note You need to log in before you can comment on or make changes to this bug.