Bug 36121

Summary: [Qt] Make WebKit scrollbars work with tiling
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: New BugsAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, kenneth, rakuco
Priority: P3 Keywords: Qt
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch
none
updated patch
hausmann: review+
Screenshot none

Antti Koivisto
Reported 2010-03-15 09:05:50 PDT
Currently tiling only works correctly when the QGraphicsWebView is in resizesToContent mode. It should work without too, using the scrollbar overlay (already implemented for accelerated compositing).
Attachments
patch (11.72 KB, patch)
2010-03-15 09:16 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
updated patch (11.77 KB, patch)
2010-03-16 05:28 PDT, Antti Koivisto 		hausmann: review+
DetailsFormatted DiffDiff
Screenshot (77.90 KB, image/png)
2010-03-16 08:57 PDT, Simon Hausmann 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2010-03-15 09:16:40 PDT
Created attachment 50713 [details] patch
Simon Hausmann
Comment 2 2010-03-15 09:50:57 PDT
This works quite well now! The vertical scrollbar is broken for me though. Do you see that, too?
Kenneth Rohde Christiansen
Comment 3 2010-03-15 14:21:54 PDT
Nice patch!
Simon Hausmann
Comment 4 2010-03-16 01:39:45 PDT
Comment on attachment 50713 [details] patch > +void QGraphicsWebViewPrivate::createOrDeleteOverlay() > +{ > + bool useOverlay = false; > +#if USE(ACCELERATED_COMPOSITING) > + useOverlay = useOverlay || rootGraphicsLayer; > +#endif > +#if ENABLE(TILED_BACKING_STORE) > + useOverlay = useOverlay || QWebFramePrivate::core(q->page()->mainFrame())->tiledBackingStore(); Isn't another condition that we need the overlay only if we're _not_ in resizesToContents mode?
Antti Koivisto
Comment 5 2010-03-16 05:09:00 PDT
(In reply to comment #2) > This works quite well now! The vertical scrollbar is broken for me though. Do > you see that, too? No, both scrollbars look and work fine (this is on mac). Anything special I need to do to see this?
Antti Koivisto
Comment 6 2010-03-16 05:28:31 PDT
Created attachment 50784 [details] updated patch
Antti Koivisto
Comment 7 2010-03-16 05:29:13 PDT
Comment on attachment 50784 [details] updated patch fixed the resizesToContents bug Simon noticed
Simon Hausmann
Comment 8 2010-03-16 08:56:24 PDT
(In reply to comment #5) > (In reply to comment #2) > > This works quite well now! The vertical scrollbar is broken for me though. Do > > you see that, too? > > No, both scrollbars look and work fine (this is on mac). Anything special I > need to do to see this? Hmmm, I see it happening on Linux with the Oxygen style. For some reason it doesn't happen with the other styles.
Simon Hausmann
Comment 9 2010-03-16 08:57:58 PDT
Created attachment 50797 [details] Screenshot Attached is a screenshot of the bug. It looks like it only affects the vertical scrollbar, and I think that could happen if the geometries passed to are weird.
Antti Koivisto
Comment 10 2010-03-16 09:57:27 PDT
Sending WebCore/ChangeLog Sending WebCore/page/Frame.cpp Sending WebKit/qt/Api/qgraphicswebview.cpp Sending WebKit/qt/Api/qwebframe.cpp Sending WebKit/qt/Api/qwebframe_p.h Sending WebKit/qt/ChangeLog Transmitting file data ...... Committed revision 56068.
Note You need to log in before you can comment on or make changes to this bug.