Bug 36810

Summary: tryLayoutDoingPositionedMovementOnly does not have to be in RenderObject or be virtual
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: Layout and RenderingAssignee: Benjamin Poulain <benjamin>
Status: CLOSED FIXED    
Severity: Normal CC: commit-queue, hausmann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 35784    
Attachments:
Description Flags
Move the function to RenderBox none

Benjamin Poulain
Reported 2010-03-30 01:18:31 PDT
As far as I know, this method only makes sense for RenderBoxes. It could be implemented there directly. That could clean the code of RenderObject a bit, and avoid a useless virtual function call in the layout path.
Attachments
Move the function to RenderBox (2.27 KB, patch)
2010-03-30 01:20 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2010-03-30 01:20:58 PDT
Created attachment 52011 [details] Move the function to RenderBox
WebKit Commit Bot
Comment 2 2010-03-31 02:50:08 PDT
Comment on attachment 52011 [details] Move the function to RenderBox Clearing flags on attachment: 52011 Committed r56831: <http://trac.webkit.org/changeset/56831>
WebKit Commit Bot
Comment 3 2010-03-31 02:50:13 PDT
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 4 2010-04-06 02:21:03 PDT
Revision r56831 cherry-picked into qtwebkit-2.0 with commit 634142ce553d451158968753b31cd1364b1472dd
Note You need to log in before you can comment on or make changes to this bug.