Bug 37226

Summary: [Qt] Remove shaderSource manipulation from GraphicsContext3DQt.cpp
Product: WebKit Reporter: Jarkko Sakkinen <jarkko.j.sakkinen>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Normal CC: commit-queue, hausmann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 35784    
Attachments:
Description Flags
Removes appending of precision and version from shaderSource none

Jarkko Sakkinen
Reported 2010-04-07 11:57:14 PDT
Remove ugly hack from GraphicsContext3D::shadeSource implementation that appends #version to shaderSource. This is all wrong and mistake by me when I first did it and it breaks lot of WebGL pages. Making sure that shader source meets WebGL specification must be handled in platform independent WebGL code.
Attachments
Removes appending of precision and version from shaderSource (1.91 KB, patch)
2010-04-07 12:45 PDT, Jarkko Sakkinen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jarkko Sakkinen
Comment 1 2010-04-07 12:45:09 PDT
Created attachment 52771 [details] Removes appending of precision and version from shaderSource
WebKit Commit Bot
Comment 2 2010-04-08 02:23:07 PDT
Comment on attachment 52771 [details] Removes appending of precision and version from shaderSource Clearing flags on attachment: 52771 Committed r57267: <http://trac.webkit.org/changeset/57267>
WebKit Commit Bot
Comment 3 2010-04-08 02:23:11 PDT
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 4 2010-04-08 03:40:15 PDT
Revision r57267 cherry-picked into qtwebkit-2.0 with commit 26ec2a2b5376ffc5810a52d5476d51ca9b860a36
Note You need to log in before you can comment on or make changes to this bug.