Bug 44475

Summary: Use new HTML5 TreeBuilder for fragment parsing
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, dumi, eric, ossy, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch abarth: review+, commit-queue: commit-queue-

Eric Seidel (no email)
Reported 2010-08-23 18:23:09 PDT
Use new HTML5 TreeBuilder for fragment parsing
Attachments
Patch (26.77 KB, patch)
2010-08-23 18:30 PDT, Eric Seidel (no email) 		abarth: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-08-23 18:30:09 PDT
Created attachment 65196 [details] Patch
Adam Barth
Comment 2 2010-08-23 18:31:31 PDT
Comment on attachment 65196 [details] Patch Yay
Eric Seidel (no email)
Comment 3 2010-08-23 18:32:08 PDT
CCing the gardner as an FYI.
WebKit Commit Bot
Comment 4 2010-08-23 21:56:09 PDT
Comment on attachment 65196 [details] Patch Rejecting patch 65196 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 20898 test cases. fast/innerHTML/innerHTML-changing-document-properties.xhtml -> failed Exiting early after 1 failures. 8150 tests run. 189.61s total testing time 8149 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 6 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/3799249
Adam Barth
Comment 5 2010-08-24 00:13:09 PDT
Committed r65868: <http://trac.webkit.org/changeset/65868>
WebKit Review Bot
Comment 6 2010-08-24 01:12:19 PDT
http://trac.webkit.org/changeset/65868 might have broken GTK Linux 32-bit Release The following changes are on the blame list: http://trac.webkit.org/changeset/65868 http://trac.webkit.org/changeset/65869
Csaba Osztrogonác
Comment 7 2010-08-24 02:14:28 PDT
It seems r65869 broke dozens of tests on Qt bot: http://build.webkit.org/results/Qt%20Linux%20Release/r65869%20%2818230%29/results.html
Adam Barth
Comment 8 2010-08-24 02:16:05 PDT
> It seems r65869 broke dozens of tests on Qt bot: > http://build.webkit.org/results/Qt%20Linux%20Release/r65869%20%2818230%29/results.html Thanks Ossy. Build.webkit.org is super slow for me, so it's hard to see what I've done.
Adam Barth
Comment 9 2010-08-24 02:19:50 PDT
Looks like one bug. Something in Qt is dumping a <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> into paste fragments.
Adam Barth
Comment 10 2010-08-24 02:20:35 PDT
Looks like Pasteboard::writeSelection. That code is likely just wrong.
Adam Barth
Comment 11 2010-08-24 02:29:13 PDT
Followup in Bug 44506.
Note You need to log in before you can comment on or make changes to this bug.