Bug 46406

Summary: Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, levin, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Dimitri Glazkov (Google)
Reported 2010-09-23 14:18:55 PDT
Fix a condition check in ServerProcess, which becomes relevant when reading binary data.
Attachments
Patch (1.56 KB, patch)
2010-09-23 14:23 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2010-09-23 14:23:24 PDT
Created attachment 68588 [details] Patch
David Levin
Comment 2 2010-09-23 14:26:51 PDT
Is a test possible?
Dirk Pranke
Comment 3 2010-09-23 14:37:52 PDT
not easily. this is embedded pretty close to some code reading directly off of sockets, and there's no easy way to mock it at the moment. I need to revamp this code in the next few days and I will be adding a lot more unit testing at that point. I stepped through this with dglazkov, and the bug is real and the fix is the right one.
Dimitri Glazkov (Google)
Comment 4 2010-09-23 14:50:16 PDT
Comment on attachment 68588 [details] Patch Clearing flags on attachment: 68588 Committed r68201: <http://trac.webkit.org/changeset/68201>
Dimitri Glazkov (Google)
Comment 5 2010-09-23 14:50:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.