Bug 49373

Summary: [Qt] Add an API for informing the actual visible contents rect to WebCore
Product: WebKit Reporter: Kenneth Rohde Christiansen <kenneth>
Component: WebKit QtAssignee: Kenneth Rohde Christiansen <kenneth>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, kling, laszlo.gombos, webkit-ews, zalan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Bug Depends on:    
Bug Blocks: 43852    
Attachments:
Description Flags
Patch
none
Patch
kling: review+, kling: commit-queue-
Fix for def file for symbian winscw kenneth: review+

Kenneth Rohde Christiansen
Reported 2010-11-11 02:20:07 PST
Used in combination with tiling and resizesToContents.
Attachments
Patch (2.87 KB, patch)
2010-11-11 02:21 PST, Kenneth Rohde Christiansen 		no flags
DetailsFormatted DiffDiff
Patch (2.88 KB, patch)
2010-11-11 03:47 PST, Kenneth Rohde Christiansen 		kling: review+
kling: commit-queue-
DetailsFormatted DiffDiff
Fix for def file for symbian winscw (8.04 KB, patch)
2011-01-10 11:41 PST, Misha 		kenneth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenneth Rohde Christiansen
Comment 1 2010-11-11 02:21:27 PST
Created attachment 73592 [details] Patch
Early Warning System Bot
Comment 2 2010-11-11 02:34:44 PST
Attachment 73592 [details] did not build on qt: Build output: http://queues.webkit.org/results/5517080
Andreas Kling
Comment 3 2010-11-11 03:13:19 PST
Comment on attachment 73592 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73592&action=review > WebKit/qt/Api/qwebpage.h:283 > + void informVisibleContentsRect(const QRect& rect) const; I don't like this name at all, can we find a better word than "inform"? setVisibleContentsRect? forceVisibleContentsRect? overrideVisibleContentsRect?
Kenneth Rohde Christiansen
Comment 4 2010-11-11 03:47:13 PST
Created attachment 73595 [details] Patch You win!
Andreas Kling
Comment 5 2010-11-11 03:54:23 PST
Comment on attachment 73595 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=73595&action=review r=me, I'll land it for you (once the WebCore change is in) with fixed ChangeLog. > WebKit/qt/ChangeLog:9 > + (QWebPage::informVisibleContentsRect): Somebody forgot to regen the ChangeLog ;)
Early Warning System Bot
Comment 6 2010-11-11 03:56:52 PST
Attachment 73595 [details] did not build on qt: Build output: http://queues.webkit.org/results/5460099
Andreas Kling
Comment 7 2010-11-11 04:47:05 PST
Committed r71806: <http://trac.webkit.org/changeset/71806>
Ademar Reis
Comment 8 2010-11-16 12:46:45 PST
What about updating the symbian .def files with this new API? (I don't know or have the tools necessary to update the .def files)
Misha
Comment 9 2011-01-10 11:41:44 PST
Created attachment 78418 [details] Fix for def file for symbian winscw I updated .def file for symbian winscw build. ARM build looks ok.
Kenneth Rohde Christiansen
Comment 10 2011-01-10 11:47:01 PST
Comment on attachment 78418 [details] Fix for def file for symbian winscw What does this ABSENT mean? The method was removed from the branch?
Kenneth Rohde Christiansen
Comment 11 2011-01-10 11:47:42 PST
(In reply to comment #10) > (From update of attachment 78418 [details]) > What does this ABSENT mean? The method was removed from the branch? I mean ViewportConfiguration was renamed long ago, can't those lines be removed instead? just wondering...
Laszlo Gombos
Comment 12 2011-01-10 12:19:28 PST
Proposed patch looks good to me for 2.1 (and likely for 2.2); not for trunk obviously. r=me. Kenneth, ABSENT is a simple way to ensure that there are no holes in the ordinal numbers - otherwise one would have to reuse the ordinal numbers for new symbols, which could be confusing for clients.
Kenneth Rohde Christiansen
Comment 13 2011-01-10 12:21:30 PST
OK, thanks for the explanation!
Note You need to log in before you can comment on or make changes to this bug.