Bug 52130

Summary: Support 'disabled' attribute on SVGStyleElement
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, betravis, krit, lmcliste, ojan, rwlbuis, WebkitBugTracker, webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
proposed patch adding disabled
none
updated patch none

Simon Fraser (smfr)
Reported 2011-01-09 09:09:42 PST
DOM1/DOM2 describe a 'disabled' attribute on HTMLStyleElements <http://www.w3.org/TR/DOM-Level-2-HTML/html.html#ID-16428977>. This is being fixed for HTML via bug 25287, but we should probably make it work for SVG also.
Attachments
proposed patch adding disabled (6.88 KB, patch)
2012-02-02 16:54 PST, Bear Travis 		no flags
DetailsFormatted DiffDiff
updated patch (7.14 KB, patch)
2012-02-02 17:51 PST, Bear Travis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Rob Buis
Comment 1 2011-05-19 15:37:37 PDT
This is probably an easy fix. However before even starting I am verifying on www-svg, because the exact wording makes it a bit hard to figure out whether this is in the SVG spec or not. Chhers, Rob.
Dirk Schulze
Comment 2 2012-02-01 18:35:55 PST
(In reply to comment #1) > This is probably an easy fix. However before even starting I am verifying on www-svg, because the exact wording makes it a bit hard to figure out whether this is in the SVG spec or not. It isn't in SVG, but it is really just copy&paste from HTMLStyleElement(idl,h,cpp) to SVGStyleElement(idl,h,cpp). But it seems to be very useful. We should suggest it on www-svg and implement it as a demonstration.
Bear Travis
Comment 3 2012-02-02 16:54:55 PST
Created attachment 125210 [details] proposed patch adding disabled
Bear Travis
Comment 4 2012-02-02 17:05:42 PST
The proposed patch adds the disabled attribute to SVGStyleElement(.idl, .h, .cpp). The code is almost identical to: https://bugs.webkit.org/show_bug.cgi?id=25287 The patch does not include the reflection tests from 25287 because SVGStyleElement does not yet have a "sheet" attribute in the .idl.
Bear Travis
Comment 5 2012-02-02 17:51:30 PST
Created attachment 125220 [details] updated patch updating patch changelogs to be more descriptive
Dirk Schulze
Comment 6 2012-02-02 20:03:55 PST
Comment on attachment 125220 [details] updated patch Great patch! r=me Please set the r? and cq? flags if you want this patch get reviewed in the future.
WebKit Review Bot
Comment 7 2012-02-02 20:51:34 PST
Comment on attachment 125220 [details] updated patch Clearing flags on attachment: 125220 Committed r106623: <http://trac.webkit.org/changeset/106623>
WebKit Review Bot
Comment 8 2012-02-02 20:51:41 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.