Bug 57778

Summary:

Create SnowLeopard Debug builder and tester

Product:

WebKit

Reporter:

Lucas Forschler <lforschler>

Component:

Tools / Tests

Assignee:

Lucas Forschler <lforschler>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aroben, commit-queue, dominicc, eric, slewis, webkit.review.bot, wsiegrist

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Patch for updating the webkit buildbot master	eric: review+, commit-queue: commit-queue-
Add SnowLeopard Debug builder and tester	none
Add snowleopard bots	none
Fix the bot names, and add the builder	none

Lucas Forschler

Reported 2011-04-04 13:11:59 PDT

per Maciej, we need a SnowLeopard Debug Test Bot. This requires a SL Debug builder. We currently build SL Debug using the leaks bot. We will need to turn the current leaks bot into a test only bot, as we are adding a SL Debug build-only bot. I believe we should wait until verifying the new debug builder is functional before changing the current leak bot functionality.

Attachments
Patch for updating the webkit buildbot master (4.43 KB, patch) 2011-04-04 13:13 PDT, Lucas Forschler	eric: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Add SnowLeopard Debug builder and tester (4.56 KB, patch) 2011-05-12 14:11 PDT, Lucas Forschler	no flags	Details Formatted Diff Diff
Add snowleopard bots (4.57 KB, patch) 2011-05-12 14:19 PDT, Lucas Forschler	no flags	Details Formatted Diff Diff
Fix the bot names, and add the builder (2.63 KB, patch) 2011-05-12 17:58 PDT, Lucas Forschler	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Lucas Forschler

Comment 1 2011-04-04 13:13:07 PDT

Created attachment 88109 [details] Patch for updating the webkit buildbot master patch to update the config.json for the buildbot master. This will require a master restart.

WebKit Review Bot

Comment 2 2011-04-04 13:13:32 PDT

Comment on attachment 88109 [details] Patch for updating the webkit buildbot master Rejecting attachment 88109 [details] from review queue. lforschler@apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights.

WebKit Review Bot

Comment 3 2011-04-04 13:42:57 PDT

Attachment 88109 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style']" exit_code: 1 Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Seidel (no email)

Comment 4 2011-04-26 16:11:33 PDT

Comment on attachment 88109 [details] Patch for updating the webkit buildbot master OK.

WebKit Commit Bot

Comment 5 2011-04-26 16:14:43 PDT

Comment on attachment 88109 [details] Patch for updating the webkit buildbot master Rejecting attachment 88109 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-7', 'apply-..." exit_code: 2 Last 500 characters of output: '--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/BuildSlaveSupport/build.webkit.org-config/config.json Hunk #3 FAILED at 241. 1 out of 4 hunks FAILED -- saving rejects to file Tools/BuildSlaveSupport/build.webkit.org-config/config.json.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/8507755

Lucas Forschler

Comment 6 2011-05-12 14:11:55 PDT

Created attachment 93338 [details] Add SnowLeopard Debug builder and tester retrying, the original patch never made it through somehow.

Stephanie Lewis

Comment 7 2011-05-12 14:14:09 PDT

Comment on attachment 93338 [details] Add SnowLeopard Debug builder and tester View in context: https://bugs.webkit.org/attachment.cgi?id=93338&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:24 > I think you met mac-snowleopard?

WebKit Review Bot

Comment 8 2011-05-12 14:14:59 PDT

Attachment 93338 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/BuildSlaveSupport/build.webkit.org-c..." exit_code: 1 Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Lucas Forschler

Comment 9 2011-05-12 14:19:47 PDT

Created attachment 93342 [details] Add snowleopard bots update...typo in last patch.

WebKit Review Bot

Comment 10 2011-05-12 14:24:32 PDT

Attachment 93342 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/BuildSlaveSupport/build.webkit.org-c..." exit_code: 1 Tools/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 11 2011-05-12 15:20:28 PDT

Comment on attachment 93342 [details] Add snowleopard bots Clearing flags on attachment: 93342 Committed r86386: <http://trac.webkit.org/changeset/86386>

WebKit Commit Bot

Comment 12 2011-05-12 15:20:32 PDT

All reviewed patches have been landed. Closing bug.

William Siegrist

Comment 13 2011-05-12 17:25:13 PDT

You seem to both apple-macpro-8 and -9, as well as apple-xserve-8 and -9. I tried changing the macpros to xserves, but you still reference a builder called "SnowLeopard Intel Debug (WebKit2 Tests)" that does not exist.

Lucas Forschler

Comment 14 2011-05-12 17:58:29 PDT

Created attachment 93376 [details] Fix the bot names, and add the builder the previous patch incorrectly mixed the bot names (macpro = xserve) Also, left out a WK2 config portion.

WebKit Commit Bot

Comment 15 2011-05-12 21:45:55 PDT

Comment on attachment 93376 [details] Fix the bot names, and add the builder Clearing flags on attachment: 93376 Committed r86411: <http://trac.webkit.org/changeset/86411>

WebKit Commit Bot

Comment 16 2011-05-12 21:46:01 PDT

All reviewed patches have been landed. Closing bug.

WebKit Commit Bot

Comment 17 2011-05-12 21:46:05 PDT

The commit-queue encountered the following flaky tests while processing attachment 93376 [details]: security/block-test.html bug 55741 (authors: beidson@apple.com, mrowe@apple.com, and sam@webkit.org) The commit-queue is continuing to process your patch.

William Siegrist

Comment 18 2011-05-13 08:35:37 PDT

apple-xserve-9 is assigned to two builders: "SnowLeopard Intel Debug (Build)" and "SnowLeopard Intel Debug (WebKit2 Tests)". Was that intentional?

Lucas Forschler

Comment 19 2011-05-13 10:26:40 PDT

It was intentional, as I don't have another machine available to bring up, and wanted to get results for these bots going. However, I think I should be able to bring up another bot next week if it falls too far behind.

Note You need to log in before you can comment on or make changes to this bug.