Bug 64242

Summary: WebSocket: Copy existing WebSocket tests
Product: WebKit Reporter: Yuta Kitamura <yutak>
Component: Tools / TestsAssignee: Yuta Kitamura <yutak>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 50099    
Attachments:
Description Flags
Patch
none
Patch v2 (Put tests under hybi/)
none
Merge to trunk to see EWS results yutak: commit-queue-

Yuta Kitamura
Reported 2011-07-10 11:35:05 PDT
To land the new WebSocket protocol implementation, we need to land existing tests under http/tests/websocket/tests and make them run correctly with the new protocol. Necessary steps are: (1) Copy existing WebSocket tests into http/tests/websocket/tests, and mark them as skipped. (2) Fix the tests so they can be run with the new protocol. Some obsolete tests may be removed in this step. (3) Land the new WebSocket protocol implementation, and unskip the tests. This bug takes care of step (1).
Attachments
Patch (233.78 KB, patch)
2011-07-10 11:53 PDT, Yuta Kitamura 		no flags
DetailsFormatted DiffDiff
Patch v2 (Put tests under hybi/) (215.52 KB, patch)
2011-07-10 23:15 PDT, Yuta Kitamura 		no flags
DetailsFormatted DiffDiff
Merge to trunk to see EWS results (215.53 KB, patch)
2011-07-10 23:48 PDT, Yuta Kitamura 		yutak: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Yuta Kitamura
Comment 1 2011-07-10 11:53:35 PDT
Created attachment 100234 [details] Patch
Yuta Kitamura
Comment 2 2011-07-10 11:54:34 PDT
Comment on attachment 100234 [details] Patch This should be committed manually, so setting cq-.
Kent Tamura
Comment 3 2011-07-10 18:06:32 PDT
Comment on attachment 100234 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100234&action=review > LayoutTests/platform/win/Skipped:1355 > +# Skipped until new WebSocket protocol is implemented. http://webkit.org/b/50099 > +http/tests/websocket/tests/alert-in-event-handler.html I prefer copy the tests into a subdirectory such as http/tests/websocket/tets/hybi/, and skip the directory. Yuta-san, what do you think?
Yuta Kitamura
Comment 4 2011-07-10 20:09:29 PDT
Comment on attachment 100234 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100234&action=review >> LayoutTests/platform/win/Skipped:1355 >> +http/tests/websocket/tests/alert-in-event-handler.html > > I prefer copy the tests into a subdirectory such as http/tests/websocket/tets/hybi/, and skip the directory. > Yuta-san, what do you think? Sure, that sounds better to me, too. I will update the patch.
Yuta Kitamura
Comment 5 2011-07-10 23:15:12 PDT
Created attachment 100245 [details] Patch v2 (Put tests under hybi/)
Kent Tamura
Comment 6 2011-07-10 23:32:51 PDT
Comment on attachment 100245 [details] Patch v2 (Put tests under hybi/) ok
Yuta Kitamura
Comment 7 2011-07-10 23:48:06 PDT
Created attachment 100246 [details] Merge to trunk to see EWS results
Yuta Kitamura
Comment 8 2011-07-10 23:50:40 PDT
Thanks, I will(In reply to comment #6) > (From update of attachment 100245 [details]) > ok Thanks, I'll commit this patch manually after results of the EWS bots are ready.
Yuta Kitamura
Comment 9 2011-07-11 00:51:38 PDT
Committed r90726: <http://trac.webkit.org/changeset/90726>
Note You need to log in before you can comment on or make changes to this bug.