Bug 67182

Summary: [WebSocket] Prevent unnecessary pywebsocket warning on layout tests
Product: WebKit Reporter: Takashi Toyoshima <toyoshim>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, tkent, webkit.review.bot, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 66924    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Takashi Toyoshima
Reported 2011-08-29 23:26:15 PDT
Some layout tests for WebSocket raised Exception to prevent unnecessary pywebsocket warning. But it doesn't work any more on latest pywebsocket because pywebsocket must terminate unexpected exception with http fallback. To realize silent abnormal closure, latest pywebsocket also provide AbortedByUserException. Layout tests should use AbortedByUserException instead of Exception.
Attachments
Patch (21.97 KB, patch)
2011-08-29 23:38 PDT, Takashi Toyoshima 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Takashi Toyoshima
Comment 1 2011-08-29 23:38:53 PDT
Created attachment 105586 [details] Patch
Kent Tamura
Comment 2 2011-08-30 00:28:26 PDT
Comment on attachment 105586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105586&action=review > LayoutTests/ChangeLog:11 > + Now pywebsocket support AbortedByUserException to prevent warning. > + This change make raise AbortedByUserException instead of Exception. Does pywebsocket 0.6b2 have AbortedByUserException?
Takashi Toyoshima
Comment 3 2011-08-30 00:36:17 PDT
Comment on attachment 105586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105586&action=review >> LayoutTests/ChangeLog:11 >> + This change make raise AbortedByUserException instead of Exception. > > Does pywebsocket 0.6b2 have AbortedByUserException? No. 0.6b2 doesn't have. Actually, 0.6b3 changes Exception handling to support http fallback in unexpected closure. Then, 0.6b4 introduce AbortedByUserException to eliminate http fallback.
Kent Tamura
Comment 4 2011-08-30 00:51:34 PDT
Comment on attachment 105586 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105586&action=review >>> LayoutTests/ChangeLog:11 >>> + This change make raise AbortedByUserException instead of Exception. >> >> Does pywebsocket 0.6b2 have AbortedByUserException? > > No. 0.6b2 doesn't have. > Actually, 0.6b3 changes Exception handling to support http fallback in unexpected closure. > Then, 0.6b4 introduce AbortedByUserException to eliminate http fallback. I see. I wondered why this patch didn't fail on cr-linux EWS with pywebsocket 0.6b2. Probably the updated scripts crashed because of no handshake.AortedByUserException.
WebKit Review Bot
Comment 5 2011-08-30 01:02:04 PDT
Comment on attachment 105586 [details] Patch Clearing flags on attachment: 105586 Committed r94057: <http://trac.webkit.org/changeset/94057>
WebKit Review Bot
Comment 6 2011-08-30 01:02:09 PDT
All reviewed patches have been landed. Closing bug.
Takashi Toyoshima
Comment 7 2011-08-30 06:46:43 PDT
This change was reverted with 66924.
Takashi Toyoshima
Comment 8 2011-08-30 06:49:37 PDT
I set review and commit-queue flags again. If 66924 is landed, this change could be landed without any change.
WebKit Review Bot
Comment 9 2011-08-31 02:05:29 PDT
Comment on attachment 105586 [details] Patch Clearing flags on attachment: 105586 Committed r94164: <http://trac.webkit.org/changeset/94164>
WebKit Review Bot
Comment 10 2011-08-31 02:05:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.